pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Geoghegan <pg@bowt.ie>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Rename and relocate freeze plan dedup routines.
Date: Thu, 12 Jan 2023 01:31:54 +0000
Message-ID: <E1pFmRd-003D1e-Pd@gemulon.postgresql.org> (raw)

Rename and relocate freeze plan dedup routines.

Rename the heapam.c freeze plan deduplication routines added by commit
9e540599 to names that follow conventions for functions in heapam.c.
Also relocate the functions so that they're next to their caller, which
runs during original execution, when FREEZE_PAGE WAL records are built.

The routines were initially placed next to (and followed the naming
conventions of) conceptually related REDO routine code, but that scheme
turned out to be kind of jarring when considered in a wider context.

Author: Peter Geoghegan <pg@bowt.ie>
Reported-By: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/20230109214308.icz26oqvt3k2274c@awork3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/50767705ed093eb4cf64f5980b3ffdfa2fc8ebc8

Modified Files
--------------
src/backend/access/heap/heapam.c | 296 +++++++++++++++++++--------------------
1 file changed, 147 insertions(+), 149 deletions(-)



Message-ID: <E1pFmRd-003D1e-Pd@gemulon.postgresql.org>
Permalink:  ../E1pFmRd-003D1e-Pd@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pFmRd-003D1e-Pd@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: pg@bowt.ie
  Subject: Re: pgsql: Rename and relocate freeze plan dedup routines.
  In-Reply-To: <E1pFmRd-003D1e-Pd@gemulon.postgresql.org>
  References: <E1pFmRd-003D1e-Pd@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox