pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add tests for regex replacement with \1 in pg_ident.conf to 0003
Date: Fri, 13 Jan 2023 01:35:43 +0000
Message-ID: <E1pG8ys-003NxB-Tq@gemulon.postgresql.org> (raw)

Add tests for regex replacement with \1 in pg_ident.conf to 0003_peer.pl

Regexp replacement with \1 in pg_ident.conf is tested in one check of
the kerberos test suite, still it requires a dependency on
--with-gssapi to be triggered.  This commit adds to the test suite of
peer authentication two tests to check the replacement of \1 in a
pg-username, coupled with a system-username regexp:
- With a subexpression in system-username, similarly to the kerberos
test suite.
- Without a subexpression in system-username, checking for a failure.
This had no coverage until now, and the error pattern is checked in the
server logs.

Author: Jelte Fennema
Discussion: https://postgr.es/m/CAGECzQRNow4MwkBjgPxywXdJU_K3a9+Pm78JB7De3yQwwkTDew@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e753ae6397fe16db8e8e5b3e34ca6d53b4eded61

Modified Files
--------------
src/test/authentication/t/003_peer.pl | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)



Message-ID: <E1pG8ys-003NxB-Tq@gemulon.postgresql.org>
Permalink:  ../E1pG8ys-003NxB-Tq@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pG8ys-003NxB-Tq@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Add tests for regex replacement with \1 in pg_ident.conf to 0003
  In-Reply-To: <E1pG8ys-003NxB-Tq@gemulon.postgresql.org>
  References: <E1pG8ys-003NxB-Tq@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox