pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Avoid creating parallel apply state hash table unless required.
Date: Fri, 13 Jan 2023 03:13:45 +0000
Message-ID: <E1pGAVl-003Oag-3F@gemulon.postgresql.org> (raw)

Avoid creating parallel apply state hash table unless required.

This hash table is used to cache the state of streaming transactions being
applied by the parallel apply workers. So, this should be created only
when we are successful in launching at least one worker. This avoids rare
case memory leak when we are never able to launch any worker.

Author: Ted Yu
Discussion: https://postgr.es/m/CALte62wg0rBR3Vj2beV=HiWo2qG9L0hzKcX=yULNER0wmf4aEw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/dca8b01f5f1f7c83c59a16393724fbd8a29ddecb

Modified Files
--------------
src/backend/replication/logical/applyparallelworker.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)



Message-ID: <E1pGAVl-003Oag-3F@gemulon.postgresql.org>
Permalink:  ../E1pGAVl-003Oag-3F@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pGAVl-003Oag-3F@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: akapila@postgresql.org
  Subject: Re: pgsql: Avoid creating parallel apply state hash table unless required.
  In-Reply-To: <E1pGAVl-003Oag-3F@gemulon.postgresql.org>
  References: <E1pGAVl-003Oag-3F@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox