pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Refactor recordExtObjInitPriv()
Date: Tue, 17 Jan 2023 19:14:29 +0000
Message-ID: <E1pHrPg-004AkX-Rp@gemulon.postgresql.org> (raw)

Refactor recordExtObjInitPriv()

Instead of half a dozen of mostly-duplicate conditional branches,
write one common one that can handle most catalogs.  We already have
all the information we need, such as which system catalog corresponds
to which catalog table and which column is the ACL column.

Reviewed-by: Nathan Bossart <nathandbossart@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/504bc485-6bd6-dd1b-fe10-e7351aeb310d@enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2a1d7071c4ed750abb8b39436bb89c7d152bddb8

Modified Files
--------------
src/backend/catalog/aclchk.c | 152 +++----------------------------------------
1 file changed, 8 insertions(+), 144 deletions(-)



Message-ID: <E1pHrPg-004AkX-Rp@gemulon.postgresql.org>
Permalink:  ../E1pHrPg-004AkX-Rp@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pHrPg-004AkX-Rp@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org
  Subject: Re: pgsql: Refactor recordExtObjInitPriv()
  In-Reply-To: <E1pHrPg-004AkX-Rp@gemulon.postgresql.org>
  References: <E1pHrPg-004AkX-Rp@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox