From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix and clarify function comment on LogicalTapeSetCreate.
Date: Mon, 23 Jan 2023 09:59:42 +0000
Message-ID: <E1pJtc5-00535o-Qf@gemulon.postgresql.org> (raw)
Fix and clarify function comment on LogicalTapeSetCreate.
Commit c4649cce39 removed the "shared" and "ntapes" arguments, but the
comment still talked about "shared". It also talked about "a shared
file handle", which was technically correct because even before commit
c4649cce39, the "shared file handle" referred to the "fileset"
argument, not "shared". But it was very confusing. Improve the
comment.
Also add a comment on what the "preallocate" argument does.
Backpatch to v15, just to make backpatching other patches easier in
the future.
Discussion: https://www.postgresql.org/message-id/af989685-91d5-aad4-8f60-1d066b5ec309@enterprisedb.com
Reviewed-by: Peter Eisentraut
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/95f62b16a3344e48ecce1ceb2882e5af24c13a1b
Modified Files
--------------
src/backend/utils/sort/logtape.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: heikki.linnakangas@iki.fi
Subject: Re: pgsql: Fix and clarify function comment on LogicalTapeSetCreate.
In-Reply-To: <E1pJtc5-00535o-Qf@gemulon.postgresql.org>
References: <E1pJtc5-00535o-Qf@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox