From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix LATERAL join test in test memoize.sql
Date: Mon, 23 Jan 2023 23:30:23 +0000
Message-ID: <E1pK6Gc-0058u5-NI@gemulon.postgresql.org> (raw)
Fix LATERAL join test in test memoize.sql
The test in question was meant to be testing Memoize to ensure it worked
correctly when the inner side of the join contained lateral vars, however,
nothing in the lateral subquery stopped it from being pulled up into the
main query, so the planner did that, and that meant no more lateral vars.
Here we add a simple ORDER BY to stop the planner from being able to
pullup the lateral subquery.
Author: Richard Guo
Discussion: https://postgr.es/m/CAMbWs4_LHJaN4L-tXpKMiPFnsCJWU1P8Xh59o0W7AA6UN99=cQ@mail.gmail.com
Backpatch-through: 14, where Memoize was added.
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/73f77ab508d1514ca604c47b6f56c5dee4dd9025
Modified Files
--------------
src/test/regress/expected/memoize.out | 8 +++++---
src/test/regress/sql/memoize.sql | 6 ++++--
2 files changed, 9 insertions(+), 5 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: drowley@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix LATERAL join test in test memoize.sql
In-Reply-To: <E1pK6Gc-0058u5-NI@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox