pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: plpython: Avoid the need to redefine *printf macros
Date: Wed, 25 Jan 2023 17:59:51 +0000
Message-ID: <E1pKk3r-005RxC-Kd@gemulon.postgresql.org> (raw)

plpython: Avoid the need to redefine *printf macros

Until now we undefined and then redefined a lot of *printf macros due to
worries about conflicts with Python.h macro definitions. Current Python.h
doesn't define any *printf macros, and older versions just defined snprintf,
vsnprintf, guarded by #if defined(MS_WIN32) && !defined(HAVE_SNPRINTF).

Thus we can replace the undefine/define section with a single
 #define HAVE_SNPRINTF 1

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/20230124165814.2njc7gnvubn2amh6@awork3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/23c12329a755ad9c70135463d3f067241daf1dcc

Modified Files
--------------
src/pl/plpython/plpython.h | 48 +++-------------------------------------------
1 file changed, 3 insertions(+), 45 deletions(-)



Message-ID: <E1pKk3r-005RxC-Kd@gemulon.postgresql.org>
Permalink:  ../E1pKk3r-005RxC-Kd@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pKk3r-005RxC-Kd@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de
  Subject: Re: pgsql: plpython: Avoid the need to redefine *printf macros
  In-Reply-To: <E1pKk3r-005RxC-Kd@gemulon.postgresql.org>
  References: <E1pKk3r-005RxC-Kd@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox