pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Remove unneeded volatile qualifiers from postmaster.c. 2+ messages / 2 participants [nested] [flat]
* pgsql: Remove unneeded volatile qualifiers from postmaster.c. @ 2023-01-28 02:09 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Thomas Munro @ 2023-01-28 02:09 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove unneeded volatile qualifiers from postmaster.c. Several flags were marked volatile and in some cases used sig_atomic_t because they were accessed from signal handlers. After commit 7389aad6, we can just use unqualified bool. Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Reviewed-by: Andres Freund <andres@anarazel.de> Discussion: https://postgr.es/m/CA%2BhUKGLMoeZNZY6gYdLUQmuoW_a8bKyLvtuZkd_zHcGVOfDzBA%40mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/8d2c1913ed3df9384973399deeb75fc1e55943fe Modified Files -------------- src/backend/postmaster/postmaster.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Remove unneeded volatile qualifier in fmgr.c. @ 2025-02-12 21:46 Nathan Bossart <nathan@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Nathan Bossart @ 2025-02-12 21:46 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove unneeded volatile qualifier in fmgr.c. Currently, the save_nestlevel variable in fmgr_security_definer() is marked volatile. While this may have been necessary when it was used in a PG_CATCH section (as explained in the comment for PG_TRY in elog.h), it appears to have been unnecessary since commit 82a47982f3, which removed its use in a PG_CATCH section. Author: Julien Rouhaud <rjuju123@gmail.com> Reviewed-by: Bertrand Drouvot <bertranddrouvot.pg@gmail.com> Discussion: https://postgr.es/m/Z6xbAgXKY2L-3d5Q%40jrouhaud Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/9e66a2b7841a5c1f929103c82c73244d3f5f3416 Modified Files -------------- src/backend/utils/fmgr/fmgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2025-02-12 21:46 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-01-28 02:09 pgsql: Remove unneeded volatile qualifiers from postmaster.c. Thomas Munro <tmunro@postgresql.org> 2025-02-12 21:46 pgsql: Remove unneeded volatile qualifier in fmgr.c. Nathan Bossart <nathan@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox