pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Nathan Bossart <nathan@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove unneeded volatile qualifier in fmgr.c.
Date: Wed, 12 Feb 2025 21:46:40 +0000
Message-ID: <E1tiKZ6-006nix-1d@gemulon.postgresql.org> (raw)

Remove unneeded volatile qualifier in fmgr.c.

Currently, the save_nestlevel variable in fmgr_security_definer()
is marked volatile.  While this may have been necessary when it was
used in a PG_CATCH section (as explained in the comment for PG_TRY
in elog.h), it appears to have been unnecessary since commit
82a47982f3, which removed its use in a PG_CATCH section.

Author: Julien Rouhaud <rjuju123@gmail.com>
Reviewed-by: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Discussion: https://postgr.es/m/Z6xbAgXKY2L-3d5Q%40jrouhaud

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9e66a2b7841a5c1f929103c82c73244d3f5f3416

Modified Files
--------------
src/backend/utils/fmgr/fmgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



view thread (2+ messages)

Message-ID: <E1tiKZ6-006nix-1d@gemulon.postgresql.org>
Permalink:  ../E1tiKZ6-006nix-1d@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1tiKZ6-006nix-1d@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: nathan@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove unneeded volatile qualifier in fmgr.c.
  In-Reply-To: <E1tiKZ6-006nix-1d@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox