pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Thomas Munro <tmunro@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Try to fix pg_upgrade test on Windows, again.
Date: Wed, 01 Feb 2023 01:42:36 +0000
Message-ID: <E1pN28x-000zhl-JC@gemulon.postgresql.org> (raw)

Try to fix pg_upgrade test on Windows, again.

Further to commit 54e72b66e, if rmtree() fails while cleaning up in
pg_upgrade, try again.  This gives our Windows unlink() wrapper a chance
to reach its wait-for-the-other-process-to-go-away logic, if the first
go around initiated the unlink of a file that a concurrently exiting
program still has open.

Discussion: https://postgr.es/m/CA%2BhUKGKCVy2%3Do%3Dd8c2Va6a_3Rpf_KkhUitkWCZ3hzuO2VwLMXA%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c2891175052772b603da6d0ae634e42b63b7f274

Modified Files
--------------
src/bin/pg_upgrade/util.c | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)



Message-ID: <E1pN28x-000zhl-JC@gemulon.postgresql.org>
Permalink:  ../E1pN28x-000zhl-JC@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pN28x-000zhl-JC@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tmunro@postgresql.org
  Subject: Re: pgsql: Try to fix pg_upgrade test on Windows, again.
  In-Reply-To: <E1pN28x-000zhl-JC@gemulon.postgresql.org>
  References: <E1pN28x-000zhl-JC@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox