pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Simplify main waiting loop of the archiver process
Date: Wed, 01 Feb 2023 06:47:52 +0000
Message-ID: <E1pN6uM-0011Vg-WA@gemulon.postgresql.org> (raw)

Simplify main waiting loop of the archiver process

As coded, the timeout given to WaitLatch() was always equal to
PGARCH_AUTOWAKE_INTERVAL, as time() was called two times repeatedly.
This simplification could have been done in d75288f.

While on it, this adjusts a comment in pgarch.c to describe the archiver
in a more neutral way.

Author: Sravan Kumar, Nathan Bossart
Reviewed-by: Kyotaro Horiguchi
Discussion: https://postgr.es/m/CA+=NbjjqYE9-Lnw7H7DAiS5jebmoMikwZQb_sBP7kgBCn9q6Hg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/38cc08546459a9052b6ed43cdb28973288db38c6

Modified Files
--------------
src/backend/postmaster/pgarch.c | 32 +++++++++++---------------------
1 file changed, 11 insertions(+), 21 deletions(-)



Message-ID: <E1pN6uM-0011Vg-WA@gemulon.postgresql.org>
Permalink:  ../E1pN6uM-0011Vg-WA@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pN6uM-0011Vg-WA@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Simplify main waiting loop of the archiver process
  In-Reply-To: <E1pN6uM-0011Vg-WA@gemulon.postgresql.org>
  References: <E1pN6uM-0011Vg-WA@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox