pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Reduce code duplication between heapgettup and heapgettup_pagemo
Date: Fri, 03 Feb 2023 03:21:13 +0000
Message-ID: <E1pNmdU-001K3n-2Q@gemulon.postgresql.org> (raw)

Reduce code duplication between heapgettup and heapgettup_pagemode

The code to get the next block number was exactly the same between these
two functions, so let's just put it into a helper function and call that
from both locations.

Author: Melanie Plageman
Reviewed-by: Andres Freund, David Rowley
Discussion: https://postgr.es/m/CAAKRu_bvkhka0CZQun28KTqhuUh5ZqY=_T8QEqZqOL02rpi2bw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7ae0ab0ad9704b10400a611a9af56c63304c27a5

Modified Files
--------------
src/backend/access/heap/heapam.c | 186 +++++++++++++++++++--------------------
1 file changed, 91 insertions(+), 95 deletions(-)



Message-ID: <E1pNmdU-001K3n-2Q@gemulon.postgresql.org>
Permalink:  ../E1pNmdU-001K3n-2Q@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pNmdU-001K3n-2Q@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: drowley@postgresql.org
  Subject: Re: pgsql: Reduce code duplication between heapgettup and heapgettup_pagemo
  In-Reply-To: <E1pNmdU-001K3n-2Q@gemulon.postgresql.org>
  References: <E1pNmdU-001K3n-2Q@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox