pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Properly NULL-terminate GSS receive buffer on error packet recep
Date: Mon, 06 Feb 2023 02:23:28 +0000
Message-ID: <E1pOrAF-001nTs-JA@gemulon.postgresql.org> (raw)

Properly NULL-terminate GSS receive buffer on error packet reception

pqsecure_open_gss() includes a code path handling error messages with
v2-style protocol messages coming from the server.  The client-side
buffer holding the error message does not force a NULL-termination, with
the data of the server getting copied to the errorMessage of the
connection.  Hence, it would be possible for a server to send an
unterminated string and copy arbitrary bytes in the buffer receiving the
error message in the client, opening the door to a crash or even data
exposure.

As at this stage of the authentication process the exchange has not been
completed yet, this could be abused by an attacker without Kerberos
credentials.  Clients that have a valid kerberos cache are vulnerable as
libpq opportunistically requests for it except if gssencmode is
disabled.

Author: Jacob Champion
Backpatch-through: 12
Security: CVE-2022-41862

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/3f7342671341a7a137f2d8b06ab3461cdb0e1d88

Modified Files
--------------
src/interfaces/libpq/fe-secure-gssapi.c | 2 ++
1 file changed, 2 insertions(+)



view thread (5+ messages)

Message-ID: <E1pOrAF-001nTs-JA@gemulon.postgresql.org>
Permalink:  ../E1pOrAF-001nTs-JA@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pOrAF-001nTs-JA@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Properly NULL-terminate GSS receive buffer on error packet recep
  In-Reply-To: <E1pOrAF-001nTs-JA@gemulon.postgresql.org>
  References: <E1pOrAF-001nTs-JA@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox