From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add support for progress reporting to pg_verifybackup
Date: Mon, 06 Feb 2023 05:42:08 +0000
Message-ID: <E1pOuGV-001ooV-7K@gemulon.postgresql.org> (raw)
Add support for progress reporting to pg_verifybackup
This adds a new option to pg_verifybackup called -P/--progress, showing
every second some information about the progress of the checksum
verification based on the data of a backup manifest.
Similarly to what is done for pg_rewind and pg_basebackup, the
information printed in the progress report consists of the current
amount of data computed and the total amount of data that will be
computed. Note that files found with an incorrect size do not have
their checksum verified, hence their size is not appended to the total
amount of data estimated during the first scan of the manifest data
(such incorrect sizes could be overly high, for one, falsifying the
progress report).
Author: Masahiko Sawada
Discussion: https://postgr.es/m/CAD21AoC5+JOgMd4o3z_oxw0f8JDSsCYY7zSbhe-O9x7f33rw_A@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d07c2948bfe577cfeaa4eb564c5e62bcb6cb1955
Modified Files
--------------
doc/src/sgml/ref/pg_verifybackup.sgml | 15 ++++++
src/bin/pg_verifybackup/pg_verifybackup.c | 86 +++++++++++++++++++++++++++++--
src/bin/pg_verifybackup/t/004_options.pl | 17 ++++--
3 files changed, 111 insertions(+), 7 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz
Subject: Re: pgsql: Add support for progress reporting to pg_verifybackup
In-Reply-To: <E1pOuGV-001ooV-7K@gemulon.postgresql.org>
References: <E1pOuGV-001ooV-7K@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox