pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: remove_rel_from_query() must clean up PlaceHolderVar.phrels fiel
Date: Wed, 08 Feb 2023 19:45:48 +0000
Message-ID: <E1pPqO3-0007o1-Qt@gemulon.postgresql.org> (raw)

remove_rel_from_query() must clean up PlaceHolderVar.phrels fields.

While we got away with this sloppiness before, it's not okay now
that fee7b77b9 caused build_joinrel_tlist() to make use of phrels.
Per report from Robins Tharakan.

Richard Guo (some cosmetic tweaks by me)

Discussion: https://postgr.es/m/CAMbWs4_ngw9sKxpTE8hqk=-ooVX_CQP3DarA4HzkRMz_JKpTrA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/798c0176342150c8fe1404b0007b299db2e73ce0

Modified Files
--------------
src/backend/optimizer/plan/analyzejoins.c | 17 ++++++++++-------
src/test/regress/expected/join.out        | 16 ++++++++++++++++
src/test/regress/sql/join.sql             |  7 +++++++
3 files changed, 33 insertions(+), 7 deletions(-)



Message-ID: <E1pPqO3-0007o1-Qt@gemulon.postgresql.org>
Permalink:  ../E1pPqO3-0007o1-Qt@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pPqO3-0007o1-Qt@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: remove_rel_from_query() must clean up PlaceHolderVar.phrels fiel
  In-Reply-To: <E1pPqO3-0007o1-Qt@gemulon.postgresql.org>
  References: <E1pPqO3-0007o1-Qt@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox