pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Further tighten nullingrel marking rules in build_joinrel_tlist(
Date: Wed, 08 Feb 2023 19:45:48 +0000
Message-ID: <E1pPqO3-0007o2-Rc@gemulon.postgresql.org> (raw)

Further tighten nullingrel marking rules in build_joinrel_tlist().

The code I added in fee7b77b9 could misbehave if commute_above_r
contains multiple relids.  While adding too many relids here is
probably harmless (pre-fee7b77b9, we did it all the time), it's
not very expensive to be accurate: we just have to intersect
commute_above_r with the join's relids.

Discussion: https://postgr.es/m/17781-c0405c8b3cd5e072@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d1c9c864fc042412e9b674d79a0e70972053ce15

Modified Files
--------------
src/backend/optimizer/util/relnode.c | 20 +++++++++++---------
1 file changed, 11 insertions(+), 9 deletions(-)



Message-ID: <E1pPqO3-0007o2-Rc@gemulon.postgresql.org>
Permalink:  ../E1pPqO3-0007o2-Rc@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pPqO3-0007o2-Rc@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Further tighten nullingrel marking rules in build_joinrel_tlist(
  In-Reply-To: <E1pPqO3-0007o2-Rc@gemulon.postgresql.org>
  References: <E1pPqO3-0007o2-Rc@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox