pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Further fixes in qual nullingrel adjustment for outer join commu
Date: Fri, 10 Feb 2023 18:31:07 +0000
Message-ID: <E1pQYAs-000Qx0-Bp@gemulon.postgresql.org> (raw)

Further fixes in qual nullingrel adjustment for outer join commutation.

One of the add_nulling_relids calls in deconstruct_distribute_oj_quals
added an OJ relid to too few Vars, while the other added it to too
many.  We should consider the syntactic structure not
min_left/righthand while deciding which Vars to decorate, and when
considering pushing up a lower outer join pursuant to transforming the
second form of OJ identity 3 to the first form, we only want to
decorate Vars coming from its LHS.

In a related bug, I realized that make_outerjoininfo was failing to
check a very basic property that's needed to apply OJ identity 3:
the syntactically-upper outer join clause can't refer to the lower
join's LHS.  This didn't break the join order restriction logic,
but it led to setting bogus commute_xxx bits, possibly resulting
in bogus nullingrel markings in modified quals.

Richard Guo and Tom Lane

Discussion: https://postgr.es/m/CAMbWs497CmBruMx1SOjepWEz+T5NWa4scqbdE9v7ZzSXqH_gQw@mail.gmail.com
Discussion: https://postgr.es/m/CAEP4nAx9C5gXNBfEA0JBfz7B+5f1Bawt-RWQWyhev-wdps8BZA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/acc5821e4dcb6b7df6ad1f806459f95fcaebadfc

Modified Files
--------------
src/backend/optimizer/plan/initsplan.c | 21 ++++++++++++++++-----
src/test/regress/expected/join.out     | 25 +++++++++++++++++++++++++
src/test/regress/sql/join.sql          |  9 +++++++++
3 files changed, 50 insertions(+), 5 deletions(-)



Message-ID: <E1pQYAs-000Qx0-Bp@gemulon.postgresql.org>
Permalink:  ../E1pQYAs-000Qx0-Bp@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pQYAs-000Qx0-Bp@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Further fixes in qual nullingrel adjustment for outer join commu
  In-Reply-To: <E1pQYAs-000Qx0-Bp@gemulon.postgresql.org>
  References: <E1pQYAs-000Qx0-Bp@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox