From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix pfree issue in presorted DISTINCT aggregate code
Date: Mon, 13 Feb 2023 10:39:09 +0000
Message-ID: <E1pRWEm-000ulR-Ch@gemulon.postgresql.org> (raw)
Fix pfree issue in presorted DISTINCT aggregate code
The logic in this area was recently changed in 7da51590e, however, in that
commit, I neglected to consider that the conditions in which we should
pfree the old Datum needed to be updated after that change. This could
result in trying to pfree a NULL value, as was demonstrated by Alexander
Lakhin.
Reported-by: Alexander Lakhin
Discussion: https://postgr.es/m/4103db46-d888-6d1d-e88d-87c21ed99472@gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/ec5a010ab25bf40012fde78b34724971e38e08a4
Modified Files
--------------
src/backend/executor/execExprInterp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: drowley@postgresql.org
Subject: Re: pgsql: Fix pfree issue in presorted DISTINCT aggregate code
In-Reply-To: <E1pRWEm-000ulR-Ch@gemulon.postgresql.org>
References: <E1pRWEm-000ulR-Ch@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox