pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove obsolete pgindent options --code-base and --build
Date: Mon, 13 Feb 2023 13:26:35 +0000
Message-ID: <E1pRYqo-000vzU-U3@gemulon.postgresql.org> (raw)

Remove obsolete pgindent options --code-base and --build

Now that we have the sources for pg_bsd_indent in our code base these
are redundant.

It is now required to provide a list of files or directories to pgindent,
either by using --commit or on the command line. The equivalent of
previously running pgindent with no parameters is now `pgindent .`

Some extra checks are also added. duplicate files in the file list are
skipped, and there is a warning if no files are specified.

If the --commit option is used, the script now chdir's to the source
root, as git always reports files relative to that. (Fixes a gripe from
Justin Pryzby)

Reviewed by Tom Lane

Discussion: https://postgr.es/m/842819.1676219054@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b16259b3c1897cf90855a94e5cb126d6c75e3cf3

Modified Files
--------------
src/tools/pgindent/pgindent     | 101 +++++-----------------------------------
src/tools/pgindent/pgindent.man |  12 +----
2 files changed, 14 insertions(+), 99 deletions(-)



Message-ID: <E1pRYqo-000vzU-U3@gemulon.postgresql.org>
Permalink:  ../E1pRYqo-000vzU-U3@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pRYqo-000vzU-U3@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andrew@dunslane.net
  Subject: Re: pgsql: Remove obsolete pgindent options --code-base and --build
  In-Reply-To: <E1pRYqo-000vzU-U3@gemulon.postgresql.org>
  References: <E1pRYqo-000vzU-U3@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox