pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tatsuo Ishii <ishii@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix make_etags failure on Mac.
Date: Wed, 15 Feb 2023 01:11:34 +0000
Message-ID: <E1pS6Kc-001Bvm-89@gemulon.postgresql.org> (raw)

Fix make_etags failure on Mac.

Previously make_etags always ran make_ctags -e when make_etags was
executed.  However, because non-Exuberant ctags on Mac does not
support -e option (and also on other platforms including old Linux),
ctags failed. To avoid the failure change make_ctags so that if
non-Exuberant ctags is used and ctags -e option is requested, run
etags command instead. If etags command does not exist, make_ctags
will fail.

Also refactor make_ctags and tweak make_etags to emit proper usage
message.

Author: Fujii Masao
Reviewed-by: Tatsuo Ishii
Discussion: https://www.postgresql.org/message-id/369c13b9-8b0f-d6f9-58fc-61258ec8f713%40oss.nttdata.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/87f21d2c68900ea4ccc6e20a9a3c941fafa9f94a

Modified Files
--------------
src/tools/make_ctags | 38 +++++++++++++++++++++++++++-----------
src/tools/make_etags |  8 +++++++-
2 files changed, 34 insertions(+), 12 deletions(-)



Message-ID: <E1pS6Kc-001Bvm-89@gemulon.postgresql.org>
Permalink:  ../E1pS6Kc-001Bvm-89@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pS6Kc-001Bvm-89@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: ishii@postgresql.org
  Subject: Re: pgsql: Fix make_etags failure on Mac.
  In-Reply-To: <E1pS6Kc-001Bvm-89@gemulon.postgresql.org>
  References: <E1pS6Kc-001Bvm-89@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox