pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Rename force_parallel_mode to debug_parallel_query
Date: Wed, 15 Feb 2023 08:22:29 +0000
Message-ID: <E1pSD3c-001Egl-IU@gemulon.postgresql.org> (raw)

Rename force_parallel_mode to debug_parallel_query

force_parallel_mode is meant to be used to allow us to exercise the
parallel query infrastructure to ensure that it's working as we expect.
It seems some users think this GUC is for forcing the query planner into
picking a parallel plan regardless of the costs.  A quick look at the
documentation would have made them realize that they were wrong, but the
GUC is likely too conveniently named which, evidently, seems to often
result in users expecting that it forces the planner into usefully
parallelizing queries.

Here we rename the GUC to something which casual users are less likely to
mistakenly think is what they need to make their query run more quickly.

For now, the old name can still be used.  We'll revisit if the old name
mapping can be removed once the buildfarm configs are all updated.

Reviewed-by: John Naylor
Discussion: https://postgr.es/m/CAApHDvrsOi92_uA7PEaHZMH-S4Xv+MGhQWA+GrP8b1kjpS1HjQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5352ca22e0012d48055453ca9992a9515d811291

Modified Files
--------------
doc/src/sgml/config.sgml                           |  8 +++---
doc/src/sgml/regress.sgml                          |  2 +-
src/backend/access/transam/parallel.c              |  4 +--
src/backend/commands/explain.c                     |  4 +--
src/backend/optimizer/plan/planmain.c              |  4 +--
src/backend/optimizer/plan/planner.c               | 20 +++++++-------
src/backend/utils/misc/guc.c                       |  1 +
src/backend/utils/misc/guc_tables.c                | 32 ++++++++++++----------
src/include/optimizer/optimizer.h                  | 12 ++++----
src/pl/plpgsql/src/pl_exec.c                       |  2 +-
src/test/isolation/expected/deadlock-parallel.out  |  6 ++--
src/test/isolation/specs/deadlock-parallel.spec    | 16 +++++------
.../isolation/specs/serializable-parallel.spec     |  2 +-
src/test/modules/libpq_pipeline/libpq_pipeline.c   |  4 +--
src/test/modules/test_oat_hooks/test_oat_hooks.c   |  2 +-
src/test/regress/expected/multirangetypes.out      |  2 +-
src/test/regress/expected/rangetypes.out           |  2 +-
src/test/regress/expected/select_parallel.out      | 12 ++++----
src/test/regress/expected/with.out                 |  2 +-
src/test/regress/sql/multirangetypes.sql           |  2 +-
src/test/regress/sql/rangetypes.sql                |  2 +-
src/test/regress/sql/select_parallel.sql           | 12 ++++----
src/test/regress/sql/with.sql                      |  2 +-
23 files changed, 79 insertions(+), 76 deletions(-)



Message-ID: <E1pSD3c-001Egl-IU@gemulon.postgresql.org>
Permalink:  ../E1pSD3c-001Egl-IU@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pSD3c-001Egl-IU@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: drowley@postgresql.org
  Subject: Re: pgsql: Rename force_parallel_mode to debug_parallel_query
  In-Reply-To: <E1pSD3c-001Egl-IU@gemulon.postgresql.org>
  References: <E1pSD3c-001Egl-IU@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox