pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Redesign archive modules
Date: Fri, 17 Feb 2023 05:32:00 +0000
Message-ID: <E1pStLj-001XOc-AN@gemulon.postgresql.org> (raw)

Redesign archive modules

A new callback named startup_cb, called shortly after a module is
loaded, is added.  This makes possible the initialization of any
additional state data required by a module.  This initial state data can
be saved in a ArchiveModuleState, that is now passed down to all the
callbacks that can be defined in a module.  With this design, it is
possible to have a per-module state, aimed at opening the door to the
support of more than one archive module.

The initialization of the callbacks is changed so as
_PG_archive_module_init() does not anymore give in input a
ArchiveModuleCallbacks that a module has to fill in with callback
definitions.  Instead, a module now needs to return a const
ArchiveModuleCallbacks.

All the structure and callback definitions of archive modules are moved
into their own header, named archive_module.h, from pgarch.h.
Command-based archiving follows the same line, with a new set of files
named shell_archive.{c,h}.

There are a few more items that are under discussion to improve the
design of archive modules, like the fact that basic_archive calls
sigsetjmp() by itself to define its own error handling flow.  These will
be adjusted later, the changes done here cover already a good portion
of what has been discussed.

Any modules created for v15 will need to be adjusted to this new
design.

Author: Nathan Bossart
Reviewed-by: Andres Freund
Discussion: https://postgr.es/m/20230130194810.6fztfgbn32e7qarj@awork3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/35739b87dcfef9fc0186aca659f262746fecd778

Modified Files
--------------
contrib/basic_archive/basic_archive.c              | 86 ++++++++++++++++++----
doc/src/sgml/archive-modules.sgml                  | 35 +++++++--
src/backend/Makefile                               |  2 +-
src/backend/archive/Makefile                       | 18 +++++
src/backend/archive/meson.build                    |  5 ++
.../{postmaster => archive}/shell_archive.c        | 41 +++++++----
src/backend/meson.build                            |  1 +
src/backend/postmaster/Makefile                    |  1 -
src/backend/postmaster/meson.build                 |  1 -
src/backend/postmaster/pgarch.c                    | 27 ++++---
src/backend/utils/misc/guc_tables.c                |  1 +
src/include/archive/archive_module.h               | 59 +++++++++++++++
src/include/archive/shell_archive.h                | 24 ++++++
src/include/postmaster/pgarch.h                    | 39 ----------
src/tools/pgindent/typedefs.list                   |  1 +
15 files changed, 252 insertions(+), 89 deletions(-)



Message-ID: <E1pStLj-001XOc-AN@gemulon.postgresql.org>
Permalink:  ../E1pStLj-001XOc-AN@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pStLj-001XOc-AN@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Redesign archive modules
  In-Reply-To: <E1pStLj-001XOc-AN@gemulon.postgresql.org>
  References: <E1pStLj-001XOc-AN@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox