pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove gratuitous assumptions about what make_modifytable can se
Date: Mon, 20 Feb 2023 17:06:42 +0000
Message-ID: <E1pU9cg-0027Df-9P@gemulon.postgresql.org> (raw)

Remove gratuitous assumptions about what make_modifytable can see.

For no clearly good reason, make_modifytable assumed that it
could not reach its get-the-FDW-info-the-hard-way path in MERGE.
It's currently possible to demonstrate that assertion failing,
which seems to be due to an upstream planner bug; but there's no
good reason to do it like this at all.  Let's apply the principle
of separation of concerns and make the MERGE check separately,
after getting or not getting the fdwroutine pointer.

Per report from Alexander Lakhin.  No test case, since I think
the potential test condition will go away soon.

Discussion: https://postgr.es/m/36bee393-b351-16ac-93b2-d46d83637e45@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c6c3b3bc3de1be016de646403b923c1c8a2521cb

Modified Files
--------------
src/backend/optimizer/plan/createplan.c | 42 ++++++++++++++++-----------------
1 file changed, 20 insertions(+), 22 deletions(-)



Message-ID: <E1pU9cg-0027Df-9P@gemulon.postgresql.org>
Permalink:  ../E1pU9cg-0027Df-9P@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pU9cg-0027Df-9P@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Remove gratuitous assumptions about what make_modifytable can se
  In-Reply-To: <E1pU9cg-0027Df-9P@gemulon.postgresql.org>
  References: <E1pU9cg-0027Df-9P@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox