pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Prevent join removal from removing the query's result relation. 2+ messages / 1 participants [nested] [flat]
* pgsql: Prevent join removal from removing the query's result relation. @ 2023-02-20 20:18 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2023-02-20 20:18 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Prevent join removal from removing the query's result relation. This was not something that required consideration before MERGE was invented; but MERGE builds a join tree that left-joins to the result relation, meaning that remove_useless_joins will consider removing it. That should generally be stopped by the query's use of output variables from the result relation. However, if the result relation is inherited (e.g. a partitioned table) then we don't add any row identity variables to the query until expand_inherited_rtentry, which happens after join removal. This was exposed as of commit 3c569049b, which made it possible to deduce that a partitioned table could contain at most one row matching a join key, enabling removal of the not-yet-expanded result relation. Ooops. To fix, let's just teach join_is_removable that the query result rel is never removable. It's a cheap enough test in any case, and it'll save some cycles that we'd otherwise expend in proving that it's not removable, even in the cases we got right. Back-patch to v15 where MERGE was added. Although I think the case cannot be reached in v15, this seems like cheap insurance. Per investigation of a report from Alexander Lakhin. Discussion: https://postgr.es/m/36bee393-b351-16ac-93b2-d46d83637e45@gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/f6db76c55509a60cc8c22ced56ff9322ee6f1742 Modified Files -------------- src/backend/optimizer/plan/analyzejoins.c | 8 +++++++ src/test/regress/expected/merge.out | 35 +++++++++++++++++++++++++++++++ src/test/regress/sql/merge.sql | 20 ++++++++++++++++++ 3 files changed, 63 insertions(+) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Prevent join removal from removing the query's result relation. @ 2023-02-20 20:18 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2023-02-20 20:18 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Prevent join removal from removing the query's result relation. This was not something that required consideration before MERGE was invented; but MERGE builds a join tree that left-joins to the result relation, meaning that remove_useless_joins will consider removing it. That should generally be stopped by the query's use of output variables from the result relation. However, if the result relation is inherited (e.g. a partitioned table) then we don't add any row identity variables to the query until expand_inherited_rtentry, which happens after join removal. This was exposed as of commit 3c569049b, which made it possible to deduce that a partitioned table could contain at most one row matching a join key, enabling removal of the not-yet-expanded result relation. Ooops. To fix, let's just teach join_is_removable that the query result rel is never removable. It's a cheap enough test in any case, and it'll save some cycles that we'd otherwise expend in proving that it's not removable, even in the cases we got right. Back-patch to v15 where MERGE was added. Although I think the case cannot be reached in v15, this seems like cheap insurance. Per investigation of a report from Alexander Lakhin. Discussion: https://postgr.es/m/36bee393-b351-16ac-93b2-d46d83637e45@gmail.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e6d8639cf25ccfffe12695768a4f7a60130c426f Modified Files -------------- src/backend/optimizer/plan/analyzejoins.c | 8 ++++++++ src/test/regress/expected/merge.out | 32 +++++++++++++++++++++++++++++++ src/test/regress/sql/merge.sql | 20 +++++++++++++++++++ 3 files changed, 60 insertions(+) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2023-02-20 20:18 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-02-20 20:18 pgsql: Prevent join removal from removing the query's result relation. Tom Lane <tgl@sss.pgh.pa.us> 2023-02-20 20:18 pgsql: Prevent join removal from removing the query's result relation. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox