pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Prevent join removal from removing the query's result relation.
Date: Mon, 20 Feb 2023 20:18:44 +0000
Message-ID: <E1pUCcV-0028io-B7@gemulon.postgresql.org> (raw)

Prevent join removal from removing the query's result relation.

This was not something that required consideration before MERGE
was invented; but MERGE builds a join tree that left-joins to the
result relation, meaning that remove_useless_joins will consider
removing it.  That should generally be stopped by the query's use
of output variables from the result relation.  However, if the
result relation is inherited (e.g. a partitioned table) then
we don't add any row identity variables to the query until
expand_inherited_rtentry, which happens after join removal.

This was exposed as of commit 3c569049b, which made it possible
to deduce that a partitioned table could contain at most one row
matching a join key, enabling removal of the not-yet-expanded
result relation.  Ooops.

To fix, let's just teach join_is_removable that the query result
rel is never removable.  It's a cheap enough test in any case,
and it'll save some cycles that we'd otherwise expend in proving
that it's not removable, even in the cases we got right.

Back-patch to v15 where MERGE was added.  Although I think the
case cannot be reached in v15, this seems like cheap insurance.

Per investigation of a report from Alexander Lakhin.

Discussion: https://postgr.es/m/36bee393-b351-16ac-93b2-d46d83637e45@gmail.com

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e6d8639cf25ccfffe12695768a4f7a60130c426f

Modified Files
--------------
src/backend/optimizer/plan/analyzejoins.c |  8 ++++++++
src/test/regress/expected/merge.out       | 32 +++++++++++++++++++++++++++++++
src/test/regress/sql/merge.sql            | 20 +++++++++++++++++++
3 files changed, 60 insertions(+)



view thread (2+ messages)

Message-ID: <E1pUCcV-0028io-B7@gemulon.postgresql.org>
Permalink:  ../E1pUCcV-0028io-B7@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pUCcV-0028io-B7@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Prevent join removal from removing the query's result relation.
  In-Reply-To: <E1pUCcV-0028io-B7@gemulon.postgresql.org>
  References: <E1pUCcV-0028io-B7@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox