pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pgbench: Prepare commands in pipelines in advance
Date: Tue, 21 Feb 2023 10:15:20 +0000
Message-ID: <E1pUPg7-002FWD-Fk@gemulon.postgresql.org> (raw)

pgbench: Prepare commands in pipelines in advance

Failing to do so results in an error when a pgbench script tries to
start a serializable transaction inside a pipeline, because by the time
BEGIN ISOLATION LEVEL SERIALIZABLE is executed, we're already in a
transaction that has acquired a snapshot, so the server rightfully
complains.

We can work around that by preparing all commands in the pipeline before
actually starting the pipeline.  This changes the existing code in two
aspects: first, we now prepare each command individually at the point
where that command is about to be executed; previously, we would prepare
all commands in a script as soon as the first command of that script
would be executed.  It's hard to see that this would make much of a
difference (particularly since it only affects the first time to execute
each script in a client), but I didn't actually try to measure it.

Secondly, we no longer use PQsendPrepare() in pipeline mode, but only
PQprepare.  There's no specific reason for this change other than no
longer needing to do differently in pipeline mode.  (Previously we had
no choice, because in pipeline mode PQprepare could not be used.)

Backpatch to 14, where pgbench got support for pipeline mode.

Reported-by: Yugo NAGATA <nagata@sraoss.co.jp>
Discussion: https://postgr.es/m/20210716153013.fc53b1c780b06fccc07a7f0d@sraoss.co.jp

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/663e50e8321192f30559a7dd68a912c43a44dcbb

Modified Files
--------------
src/bin/pgbench/pgbench.c                    | 162 ++++++++++++++++++---------
src/bin/pgbench/t/001_pgbench_with_server.pl |  20 ++++
2 files changed, 130 insertions(+), 52 deletions(-)



view thread (3+ messages)

Message-ID: <E1pUPg7-002FWD-Fk@gemulon.postgresql.org>
Permalink:  ../E1pUPg7-002FWD-Fk@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pUPg7-002FWD-Fk@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org
  Subject: Re: pgsql: pgbench: Prepare commands in pipelines in advance
  In-Reply-To: <E1pUPg7-002FWD-Fk@gemulon.postgresql.org>
  References: <E1pUPg7-002FWD-Fk@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox