pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Thomas Munro <tmunro@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove obsolete coding for early macOS.
Date: Tue, 21 Feb 2023 20:56:41 +0000
Message-ID: <E1pUZgm-0001Y0-TN@gemulon.postgresql.org> (raw)

Remove obsolete coding for early macOS.

Commits 04cad8f7 and 0c088568 supported old macOS systems that didn't
define O_CLOEXEC or O_DSYNC yet, but those arrived in macOS releases
10.7 and 10.6 (respectively), which themselves reached EOL around a
decade ago.  We've already made use of other POSIX features that early
macOS vintages can't compile (for example commits 623cc673, d2e15083).

A later commit will use O_CLOEXEC on POSIX systems so it would be
strange to pretend here that it's optional, and we might as well give
O_DSYNC the same treatment since the reference is also guarded by a test
for a macOS-specific macro, and we know that current Macs have it.

Discussion: https://postgr.es/m/CA%2BhUKGKb6FsAdQWcRL35KJsftv%2B9zXqQbzwkfRf1i0J2e57%2BhQ%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a1f45f69bbfc4b44c8adb708e4a4f6db65a67a64

Modified Files
--------------
src/backend/storage/file/fd.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)



Message-ID: <E1pUZgm-0001Y0-TN@gemulon.postgresql.org>
Permalink:  ../E1pUZgm-0001Y0-TN@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pUZgm-0001Y0-TN@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tmunro@postgresql.org
  Subject: Re: pgsql: Remove obsolete coding for early macOS.
  In-Reply-To: <E1pUZgm-0001Y0-TN@gemulon.postgresql.org>
  References: <E1pUZgm-0001Y0-TN@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox