pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Dean Rasheed <dean.a.rasheed@gmail.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add missing support for the latest SPI status codes.
Date: Wed, 22 Feb 2023 13:32:34 +0000
Message-ID: <E1pUpEY-0008as-2T@gemulon.postgresql.org> (raw)

Add missing support for the latest SPI status codes.

SPI_result_code_string() was missing support for SPI_OK_TD_REGISTER,
and in v15 and later, it was missing support for SPI_OK_MERGE, as was
pltcl_process_SPI_result().

The last of those would trigger an error if a MERGE was executed from
PL/Tcl. The others seem fairly innocuous, but worth fixing.

Back-patch to all supported branches. Before v15, this is just adding
SPI_OK_TD_REGISTER to SPI_result_code_string(), which is unlikely to
be seen by anyone, but seems worth doing for completeness.

Reviewed by Tom Lane.

Discussion:
  https://postgr.es/m/CAEZATCUg8V%2BK%2BGcafOPqymxk84Y_prXgfe64PDoopjLFH6Z0Aw%40mail.gmail.com
  https://postgr.es/m/CAEZATCUMe%2B_KedPMM9AxKqm%3DSZogSxjUcrMe%2BsakusZh3BFcQw%40mail.gmail.com

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/576b25bfd0e9a1d5bbc54931e888135bc6da8a2f

Modified Files
--------------
doc/src/sgml/spi.sgml      | 9 +++++++++
src/backend/executor/spi.c | 4 ++++
src/pl/tcl/pltcl.c         | 1 +
3 files changed, 14 insertions(+)



view thread (6+ messages)  latest in thread

Message-ID: <E1pUpEY-0008as-2T@gemulon.postgresql.org>
Permalink:  ../E1pUpEY-0008as-2T@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pUpEY-0008as-2T@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: dean.a.rasheed@gmail.com
  Subject: Re: pgsql: Add missing support for the latest SPI status codes.
  In-Reply-To: <E1pUpEY-0008as-2T@gemulon.postgresql.org>
  References: <E1pUpEY-0008as-2T@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox