pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_rewind: Fix determining TLI when server was just promoted.
Date: Thu, 23 Feb 2023 13:40:38 +0000
Message-ID: <E1pVBpt-000JBM-R0@gemulon.postgresql.org> (raw)

pg_rewind: Fix determining TLI when server was just promoted.

If the source server was just promoted, and it hasn't written the
checkpoint record yet, pg_rewind considered the server to be still on
the old timeline. Because of that, it would claim incorrectly that no
rewind is required. Fix that by looking at minRecoveryPointTLI in the
control file in addition to the ThisTimeLineID on the checkpoint.

This has been a known issue since forever, and we had worked around it
in the regression tests by issuing a checkpoint after each promotion,
before running pg_rewind. But that was always quite hacky, so better
to fix this properly. This doesn't add any new tests for this, but
removes the previously-added workarounds from the existing tests, so
that they should occasionally hit this codepath again.

This is arguably a bug fix, but don't backpatch because we haven't
really treated it as a bug so far. Also, the patch didn't apply
cleanly to v13 and below. I'm sure sure it could be made to work on
v13, but doesn't seem worth the risk and effort.

Reviewed-by: Kyotaro Horiguchi, Ibrar Ahmed, Aleksander Alekseev
Discussion: https://www.postgresql.org/message-id/9f568c97-87fe-a716-bd39-65299b8a60f4%40iki.fi

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/009eeee746825090ec7194321a3db4b298d6571e

Modified Files
--------------
src/bin/pg_rewind/pg_rewind.c                 | 105 ++++++++++++++++----------
src/bin/pg_rewind/t/007_standby_source.pl     |   1 -
src/bin/pg_rewind/t/008_min_recovery_point.pl |   9 ---
src/bin/pg_rewind/t/RewindTest.pm             |   8 --
4 files changed, 64 insertions(+), 59 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1pVBpt-000JBM-R0@gemulon.postgresql.org>
Permalink:  ../E1pVBpt-000JBM-R0@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pVBpt-000JBM-R0@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: heikki.linnakangas@iki.fi
  Subject: Re: pgsql: pg_rewind: Fix determining TLI when server was just promoted.
  In-Reply-To: <E1pVBpt-000JBM-R0@gemulon.postgresql.org>
  References: <E1pVBpt-000JBM-R0@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox