pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Prepare pg_dump internals for additional compression methods
Date: Thu, 23 Feb 2023 15:23:15 +0000
Message-ID: <E1pVDRD-000Jn8-6T@gemulon.postgresql.org> (raw)

Prepare pg_dump internals for additional compression methods

Commit bf9aa490db introduced a compression API in compress_io.{c,h} to
make reuse easier, and allow adding more compression algorithms.
However, pg_backup_archiver.c was not switched to this API and continued
to call the compression directly.

This commit teaches pg_backup_archiver.c about the compression API, so
that it can benefit from bf9aa490db (simpler code, easier addition of
new compression methods).

Author: Georgios Kokolatos
Reviewed-by: Michael Paquier, Rachel Heaton, Justin Pryzby, Tomas Vondra
Discussion: https://postgr.es/m/faUNEOpts9vunEaLnmxmG-DldLSg_ql137OC3JYDmgrOMHm1RvvWY2IdBkv_CRxm5spCCb_OmKNk2T03...

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/03d02f54a64089284582cc60d94a8af09ff4e081

Modified Files
--------------
src/bin/pg_dump/compress_io.c        |  97 ++++++++++++++++++++----
src/bin/pg_dump/compress_io.h        |   4 +
src/bin/pg_dump/pg_backup_archiver.c | 138 +++++++++++++----------------------
src/bin/pg_dump/pg_backup_archiver.h |  27 +------
4 files changed, 138 insertions(+), 128 deletions(-)



Message-ID: <E1pVDRD-000Jn8-6T@gemulon.postgresql.org>
Permalink:  ../E1pVDRD-000Jn8-6T@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pVDRD-000Jn8-6T@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tomas.vondra@postgresql.org
  Subject: Re: pgsql: Prepare pg_dump internals for additional compression methods
  In-Reply-To: <E1pVDRD-000Jn8-6T@gemulon.postgresql.org>
  References: <E1pVDRD-000Jn8-6T@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox