pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Don't repeatedly register cache callbacks in pgoutput plugin.
Date: Thu, 23 Feb 2023 20:40:59 +0000
Message-ID: <E1pVIOg-000MOn-LD@gemulon.postgresql.org> (raw)

Don't repeatedly register cache callbacks in pgoutput plugin.

Multiple cycles of starting up and shutting down the plugin within a
single session would eventually lead to "out of relcache_callback_list
slots", because pgoutput_startup blindly re-registered its cache
callbacks each time.  Fix it to register them only once, as all other
users of cache callbacks already take care to do.

This has been broken all along, so back-patch to all supported branches.

Shi Yu

Discussion: https://postgr.es/m/OSZPR01MB631004A78D743D68921FFAD3FDA79@OSZPR01MB6310.jpnprd01.prod.outlook.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/05172f1f37496acc13769b8cc0af6e77591be90f

Modified Files
--------------
src/backend/replication/pgoutput/pgoutput.c | 26 ++++++++++++++++++++++----
1 file changed, 22 insertions(+), 4 deletions(-)



view thread (6+ messages)  latest in thread

Message-ID: <E1pVIOg-000MOn-LD@gemulon.postgresql.org>
Permalink:  ../E1pVIOg-000MOn-LD@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pVIOg-000MOn-LD@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Don't repeatedly register cache callbacks in pgoutput plugin.
  In-Reply-To: <E1pVIOg-000MOn-LD@gemulon.postgresql.org>
  References: <E1pVIOg-000MOn-LD@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox