pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Don't repeatedly register cache callbacks in pgoutput plugin. 6+ messages / 1 participants [nested] [flat]
* pgsql: Don't repeatedly register cache callbacks in pgoutput plugin. @ 2023-02-23 20:40 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2023-02-23 20:40 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't repeatedly register cache callbacks in pgoutput plugin. Multiple cycles of starting up and shutting down the plugin within a single session would eventually lead to "out of relcache_callback_list slots", because pgoutput_startup blindly re-registered its cache callbacks each time. Fix it to register them only once, as all other users of cache callbacks already take care to do. This has been broken all along, so back-patch to all supported branches. Shi Yu Discussion: https://postgr.es/m/OSZPR01MB631004A78D743D68921FFAD3FDA79@OSZPR01MB6310.jpnprd01.prod.outlook.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/05172f1f37496acc13769b8cc0af6e77591be90f Modified Files -------------- src/backend/replication/pgoutput/pgoutput.c | 26 ++++++++++++++++++++++---- 1 file changed, 22 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Don't repeatedly register cache callbacks in pgoutput plugin. @ 2023-02-23 20:40 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2023-02-23 20:40 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't repeatedly register cache callbacks in pgoutput plugin. Multiple cycles of starting up and shutting down the plugin within a single session would eventually lead to "out of relcache_callback_list slots", because pgoutput_startup blindly re-registered its cache callbacks each time. Fix it to register them only once, as all other users of cache callbacks already take care to do. This has been broken all along, so back-patch to all supported branches. Shi Yu Discussion: https://postgr.es/m/OSZPR01MB631004A78D743D68921FFAD3FDA79@OSZPR01MB6310.jpnprd01.prod.outlook.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/cef1c9c0cf6e50ebe6d578d93a5d89e40774f764 Modified Files -------------- src/backend/replication/pgoutput/pgoutput.c | 26 ++++++++++++++++++++++---- 1 file changed, 22 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Don't repeatedly register cache callbacks in pgoutput plugin. @ 2023-02-23 20:40 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2023-02-23 20:40 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't repeatedly register cache callbacks in pgoutput plugin. Multiple cycles of starting up and shutting down the plugin within a single session would eventually lead to "out of relcache_callback_list slots", because pgoutput_startup blindly re-registered its cache callbacks each time. Fix it to register them only once, as all other users of cache callbacks already take care to do. This has been broken all along, so back-patch to all supported branches. Shi Yu Discussion: https://postgr.es/m/OSZPR01MB631004A78D743D68921FFAD3FDA79@OSZPR01MB6310.jpnprd01.prod.outlook.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0f78df719a90e3f992304f63b146b178e676bed2 Modified Files -------------- src/backend/replication/pgoutput/pgoutput.c | 24 +++++++++++++++++++++--- 1 file changed, 21 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Don't repeatedly register cache callbacks in pgoutput plugin. @ 2023-02-23 20:40 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2023-02-23 20:40 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't repeatedly register cache callbacks in pgoutput plugin. Multiple cycles of starting up and shutting down the plugin within a single session would eventually lead to "out of relcache_callback_list slots", because pgoutput_startup blindly re-registered its cache callbacks each time. Fix it to register them only once, as all other users of cache callbacks already take care to do. This has been broken all along, so back-patch to all supported branches. Shi Yu Discussion: https://postgr.es/m/OSZPR01MB631004A78D743D68921FFAD3FDA79@OSZPR01MB6310.jpnprd01.prod.outlook.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/861e9e48601b41ab3827ba5d22990c17ed6dcf8c Modified Files -------------- src/backend/replication/pgoutput/pgoutput.c | 24 +++++++++++++++++++++--- 1 file changed, 21 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Don't repeatedly register cache callbacks in pgoutput plugin. @ 2023-02-23 20:40 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2023-02-23 20:40 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't repeatedly register cache callbacks in pgoutput plugin. Multiple cycles of starting up and shutting down the plugin within a single session would eventually lead to "out of relcache_callback_list slots", because pgoutput_startup blindly re-registered its cache callbacks each time. Fix it to register them only once, as all other users of cache callbacks already take care to do. This has been broken all along, so back-patch to all supported branches. Shi Yu Discussion: https://postgr.es/m/OSZPR01MB631004A78D743D68921FFAD3FDA79@OSZPR01MB6310.jpnprd01.prod.outlook.com Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/95558bc8ff89c5887f1bffc9d152ca603637e2c0 Modified Files -------------- src/backend/replication/pgoutput/pgoutput.c | 24 +++++++++++++++++++++--- 1 file changed, 21 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Don't repeatedly register cache callbacks in pgoutput plugin. @ 2023-02-23 20:40 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2023-02-23 20:40 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't repeatedly register cache callbacks in pgoutput plugin. Multiple cycles of starting up and shutting down the plugin within a single session would eventually lead to "out of relcache_callback_list slots", because pgoutput_startup blindly re-registered its cache callbacks each time. Fix it to register them only once, as all other users of cache callbacks already take care to do. This has been broken all along, so back-patch to all supported branches. Shi Yu Discussion: https://postgr.es/m/OSZPR01MB631004A78D743D68921FFAD3FDA79@OSZPR01MB6310.jpnprd01.prod.outlook.com Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/44dbc960f6711e32118a8da71f251d65e0630caa Modified Files -------------- src/backend/replication/pgoutput/pgoutput.c | 24 +++++++++++++++++++++--- 1 file changed, 21 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2023-02-23 20:40 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-02-23 20:40 pgsql: Don't repeatedly register cache callbacks in pgoutput plugin. Tom Lane <tgl@sss.pgh.pa.us> 2023-02-23 20:40 pgsql: Don't repeatedly register cache callbacks in pgoutput plugin. Tom Lane <tgl@sss.pgh.pa.us> 2023-02-23 20:40 pgsql: Don't repeatedly register cache callbacks in pgoutput plugin. Tom Lane <tgl@sss.pgh.pa.us> 2023-02-23 20:40 pgsql: Don't repeatedly register cache callbacks in pgoutput plugin. Tom Lane <tgl@sss.pgh.pa.us> 2023-02-23 20:40 pgsql: Don't repeatedly register cache callbacks in pgoutput plugin. Tom Lane <tgl@sss.pgh.pa.us> 2023-02-23 20:40 pgsql: Don't repeatedly register cache callbacks in pgoutput plugin. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox