pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: pageinspect: Fix crash with gist_page_items()
3+ messages / 1 participants
[nested] [flat]

* pgsql: pageinspect: Fix crash with gist_page_items()
@ 2023-03-02 05:04 Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 3+ messages in thread

From: Michael Paquier @ 2023-03-02 05:04 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

pageinspect: Fix crash with gist_page_items()

Attempting to use this function with a raw page not coming from a GiST
index would cause a crash, as it was missing the same sanity checks as
gist_page_items_bytea().  This slightly refactors the code so as all the
basic validation checks for GiST pages are done in a single routine,
in the same fashion as the pageinspect functions for hash and BRIN.

This fixes an issue similar to 076f4d9.  A test is added to stress for
this case.  While on it, I have added a similar test for
brin_page_items() with a combination make of a valid GiST index and a
raw btree page.  This one was already protected, but it was not tested.

Reported-by: Egor Chindyaskin
Author: Dmitry Koval
Discussion: https://postgr.es/m/17815-fc4a2d3b74705703@postgresql.org
Backpatch-through: 14

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/be753639d35df72c1a7b42ec114393fd962f2b01

Modified Files
--------------
contrib/pageinspect/expected/brin.out |  8 ++--
contrib/pageinspect/expected/gist.out | 10 +++--
contrib/pageinspect/gistfuncs.c       | 82 +++++++++++++++++------------------
contrib/pageinspect/sql/brin.sql      |  8 ++--
contrib/pageinspect/sql/gist.sql      | 10 +++--
5 files changed, 62 insertions(+), 56 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* pgsql: pageinspect: Fix crash with gist_page_items()
@ 2023-03-02 05:04 Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 3+ messages in thread

From: Michael Paquier @ 2023-03-02 05:04 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

pageinspect: Fix crash with gist_page_items()

Attempting to use this function with a raw page not coming from a GiST
index would cause a crash, as it was missing the same sanity checks as
gist_page_items_bytea().  This slightly refactors the code so as all the
basic validation checks for GiST pages are done in a single routine,
in the same fashion as the pageinspect functions for hash and BRIN.

This fixes an issue similar to 076f4d9.  A test is added to stress for
this case.  While on it, I have added a similar test for
brin_page_items() with a combination make of a valid GiST index and a
raw btree page.  This one was already protected, but it was not tested.

Reported-by: Egor Chindyaskin
Author: Dmitry Koval
Discussion: https://postgr.es/m/17815-fc4a2d3b74705703@postgresql.org
Backpatch-through: 14

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/9d41ecfcd9a7cb4ec6b20add4a55603ebba03f0d

Modified Files
--------------
contrib/pageinspect/expected/brin.out |  8 ++--
contrib/pageinspect/expected/gist.out | 10 +++--
contrib/pageinspect/gistfuncs.c       | 82 +++++++++++++++++------------------
contrib/pageinspect/sql/brin.sql      |  8 ++--
contrib/pageinspect/sql/gist.sql      | 10 +++--
5 files changed, 62 insertions(+), 56 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* pgsql: pageinspect: Fix crash with gist_page_items()
@ 2023-03-02 05:04 Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 3+ messages in thread

From: Michael Paquier @ 2023-03-02 05:04 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

pageinspect: Fix crash with gist_page_items()

Attempting to use this function with a raw page not coming from a GiST
index would cause a crash, as it was missing the same sanity checks as
gist_page_items_bytea().  This slightly refactors the code so as all the
basic validation checks for GiST pages are done in a single routine,
in the same fashion as the pageinspect functions for hash and BRIN.

This fixes an issue similar to 076f4d9.  A test is added to stress for
this case.  While on it, I have added a similar test for
brin_page_items() with a combination make of a valid GiST index and a
raw btree page.  This one was already protected, but it was not tested.

Reported-by: Egor Chindyaskin
Author: Dmitry Koval
Discussion: https://postgr.es/m/17815-fc4a2d3b74705703@postgresql.org
Backpatch-through: 14

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5ad63eee13e70eeff9659bcee024e8249b6bf68c

Modified Files
--------------
contrib/pageinspect/expected/brin.out |  8 ++--
contrib/pageinspect/expected/gist.out | 10 +++--
contrib/pageinspect/gistfuncs.c       | 82 +++++++++++++++++------------------
contrib/pageinspect/sql/brin.sql      |  8 ++--
contrib/pageinspect/sql/gist.sql      | 10 +++--
5 files changed, 62 insertions(+), 56 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2023-03-02 05:04 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-03-02 05:04 pgsql: pageinspect: Fix crash with gist_page_items() Michael Paquier <michael@paquier.xyz>
2023-03-02 05:04 pgsql: pageinspect: Fix crash with gist_page_items() Michael Paquier <michael@paquier.xyz>
2023-03-02 05:04 pgsql: pageinspect: Fix crash with gist_page_items() Michael Paquier <michael@paquier.xyz>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox