pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pageinspect: Fix crash with gist_page_items()
Date: Thu, 02 Mar 2023 05:04:31 +0000
Message-ID: <E1pXb7G-001Tco-Mq@gemulon.postgresql.org> (raw)

pageinspect: Fix crash with gist_page_items()

Attempting to use this function with a raw page not coming from a GiST
index would cause a crash, as it was missing the same sanity checks as
gist_page_items_bytea().  This slightly refactors the code so as all the
basic validation checks for GiST pages are done in a single routine,
in the same fashion as the pageinspect functions for hash and BRIN.

This fixes an issue similar to 076f4d9.  A test is added to stress for
this case.  While on it, I have added a similar test for
brin_page_items() with a combination make of a valid GiST index and a
raw btree page.  This one was already protected, but it was not tested.

Reported-by: Egor Chindyaskin
Author: Dmitry Koval
Discussion: https://postgr.es/m/17815-fc4a2d3b74705703@postgresql.org
Backpatch-through: 14

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/9d41ecfcd9a7cb4ec6b20add4a55603ebba03f0d

Modified Files
--------------
contrib/pageinspect/expected/brin.out |  8 ++--
contrib/pageinspect/expected/gist.out | 10 +++--
contrib/pageinspect/gistfuncs.c       | 82 +++++++++++++++++------------------
contrib/pageinspect/sql/brin.sql      |  8 ++--
contrib/pageinspect/sql/gist.sql      | 10 +++--
5 files changed, 62 insertions(+), 56 deletions(-)



view thread (3+ messages)  latest in thread

Message-ID: <E1pXb7G-001Tco-Mq@gemulon.postgresql.org>
Permalink:  ../E1pXb7G-001Tco-Mq@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pXb7G-001Tco-Mq@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: pageinspect: Fix crash with gist_page_items()
  In-Reply-To: <E1pXb7G-001Tco-Mq@gemulon.postgresql.org>
  References: <E1pXb7G-001Tco-Mq@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox