pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Make some xlogreader messages more accurate
Date: Thu, 02 Mar 2023 06:59:55 +0000
Message-ID: <E1pXcuw-001UZU-Tr@gemulon.postgresql.org> (raw)

Make some xlogreader messages more accurate

When you have some invalid WAL, you often get a message like "wanted
24, got 0".  This is a bit incorrect, since it really wanted *at
least* 24, not exactly 24.  This updates the messages to that effect,
and also adds that detail to one message where it was available but
not printed.

Reviewed-by: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Reviewed-by: Jeevan Ladhe <jeevanladhe.os@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/726d782b-5e45-0c3e-d775-6686afe9aa83%40enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4ac30ba4f29d4b586b131404b0d514f16501272a

Modified Files
--------------
src/backend/access/transam/xlogreader.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)



Message-ID: <E1pXcuw-001UZU-Tr@gemulon.postgresql.org>
Permalink:  ../E1pXcuw-001UZU-Tr@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pXcuw-001UZU-Tr@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org
  Subject: Re: pgsql: Make some xlogreader messages more accurate
  In-Reply-To: <E1pXcuw-001UZU-Tr@gemulon.postgresql.org>
  References: <E1pXcuw-001UZU-Tr@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox