pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Refactor more the regression tests of pg_stat_statements
Date: Thu, 02 Mar 2023 23:47:05 +0000
Message-ID: <E1pXsdc-001bAy-KH@gemulon.postgresql.org> (raw)

Refactor more the regression tests of pg_stat_statements

This commit expands more the refactoring of the regression tests of
pg_stat_statements, with tests moved out of pg_stat_statements.sql into
separate files.  The following file structure is now used:
- select is mostly the former pg_stat_statements.sql, renamed.
- dml for INSERT/UPDATE/DELETE and MERGE
- user_activity, to test role-level checks and stat resets.
- wal, to check the WAL generation after some queries.

Like e8dbdb1, there is no change in terms of code coverage or results,
and this finishes the split I was aiming for in these tests.  Most of
the tests used "test" of "pgss_test" as names for the tables used, these
are renamed to less generic names.

Reviewed-by: Bertrand Drouvot
Discussion: https://postgr.es/m/Y/7Y9U/y/keAW3qH@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d0028e35a05ac71aebf28325c8ddb59a27cb63c0

Modified Files
--------------
contrib/pg_stat_statements/Makefile                |   4 +-
contrib/pg_stat_statements/expected/dml.out        | 147 ++++
.../expected/pg_stat_statements.out                | 768 ---------------------
contrib/pg_stat_statements/expected/select.out     | 414 +++++++++++
.../pg_stat_statements/expected/user_activity.out  | 199 ++++++
contrib/pg_stat_statements/expected/wal.out        |  33 +
contrib/pg_stat_statements/meson.build             |   5 +-
contrib/pg_stat_statements/sql/dml.sql             |  76 ++
.../pg_stat_statements/sql/pg_stat_statements.sql  | 300 --------
contrib/pg_stat_statements/sql/select.sql          | 149 ++++
contrib/pg_stat_statements/sql/user_activity.sql   |  65 ++
contrib/pg_stat_statements/sql/wal.sql             |  20 +
12 files changed, 1109 insertions(+), 1071 deletions(-)



Message-ID: <E1pXsdc-001bAy-KH@gemulon.postgresql.org>
Permalink:  ../E1pXsdc-001bAy-KH@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pXsdc-001bAy-KH@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Refactor more the regression tests of pg_stat_statements
  In-Reply-To: <E1pXsdc-001bAy-KH@gemulon.postgresql.org>
  References: <E1pXsdc-001bAy-KH@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox