pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Force testing of query jumbling in 027_stream_regress.pl
Date: Fri, 03 Mar 2023 01:43:26 +0000
Message-ID: <E1pXuSD-001c4N-PH@gemulon.postgresql.org> (raw)

Force testing of query jumbling in 027_stream_regress.pl

Coverage of the query jumbling code has always relied on the queries
included in the regression tests of pg_stat_statements.  This has its
limitations, as a lot of query patterns have never really stressed the
query jumbling code.  The situation got a bit worse since the query
jumbling has been added in the backend core code (5fd9dfa), hence new
nodes that should be included in the jumbling could easily be missed,
resulting in failures in pg_stat_statements or any modules that require
query ID computations.  Forcing a load of pg_stat_statements in
027_stream_regress.pl ensures that nodes are never missed in the
computations, without having to rely on a buildfarm member for this
check.

Before this commit, the line coverage of queryjumblefuncs.funcs.c was
around 48.5%, now up to 94.6% just by running 027_stream_regress.pl.
A basic check is added to show that pg_stat_statements reports are
generated after the main regression test suite is finished.

Discussion: https://postgr.es/m/Y+nD9LN70w+8eaG9@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d28a449854202d0a409e13e2e73f78373da1ed75

Modified Files
--------------
src/test/recovery/Makefile                |  2 +-
src/test/recovery/README                  |  3 ++-
src/test/recovery/t/027_stream_regress.pl | 33 +++++++++++++++++++++++++++++++
3 files changed, 36 insertions(+), 2 deletions(-)



Message-ID: <E1pXuSD-001c4N-PH@gemulon.postgresql.org>
Permalink:  ../E1pXuSD-001c4N-PH@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pXuSD-001c4N-PH@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Force testing of query jumbling in 027_stream_regress.pl
  In-Reply-To: <E1pXuSD-001c4N-PH@gemulon.postgresql.org>
  References: <E1pXuSD-001c4N-PH@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox