pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve the regression tests of VACUUM (PROCESS_TOAST)
Date: Mon, 06 Mar 2023 06:41:27 +0000
Message-ID: <E1pZ4XG-0029NV-U0@gemulon.postgresql.org> (raw)

Improve the regression tests of VACUUM (PROCESS_TOAST)

All the regression tests of VACUUM (PROCESS_TOAST) were only checking if
the commands were able to run, without checking if VACUUM was really
running on what it should.  This expands this set of tests so as we now
look at pg_stat_all_tables.vacuum_count to see how many vacuums have
been run on a given table and its toast relation.

Extracted from a larger patch by the same author, as this is useful on
its own.

Special thanks to Álvaro Herrera for the idea of using
pg_stat_all_tables to check the state of the toast relation.

Author: Nathan Bossart
Reviewed-by: Masahiko Sawada
Discussion: https://postgr.es/m/20221230000028.GA435655@nathanxps13

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/46d490ac19a7ca93a5c0f47e5a0e759b5385a8ae

Modified Files
--------------
src/test/regress/expected/vacuum.out | 36 ++++++++++++++++++++++++++++++++----
src/test/regress/sql/vacuum.sql      | 24 ++++++++++++++++++++----
2 files changed, 52 insertions(+), 8 deletions(-)



Message-ID: <E1pZ4XG-0029NV-U0@gemulon.postgresql.org>
Permalink:  ../E1pZ4XG-0029NV-U0@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pZ4XG-0029NV-U0@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Improve the regression tests of VACUUM (PROCESS_TOAST)
  In-Reply-To: <E1pZ4XG-0029NV-U0@gemulon.postgresql.org>
  References: <E1pZ4XG-0029NV-U0@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox