pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Daniel Gustafsson <dgustafsson@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix handling of default option values in createuser
Date: Mon, 06 Mar 2023 13:19:53 +0000
Message-ID: <E1pZAkq-002BxW-Rd@gemulon.postgresql.org> (raw)

Fix handling of default option values in createuser

Add description of which one is the default between two complementary
options of --bypassrls and --replication in the help text and docs. In
correspondence let the command always include the tokens corresponding
to every options of that kind in the SQL command sent to server. Tests
are updated accordingly.

Also fix the checks of some trivalue vars which were using literal zero
for checking default value instead of the enum label TRI_DEFAULT. While
not a bug, since TRI_DEFAULT is defined as zero, fixing improves read-
ability improved readability (and avoid bugs if the enum is changed).

Author: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/20220810.151243.1073197628358749087.horikyota.ntt@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d3406d80360776bbcafa05d8b966806012f9594e

Modified Files
--------------
doc/src/sgml/ref/createuser.sgml    |  2 +-
src/bin/scripts/createuser.c        | 21 ++++++++++++++-------
src/bin/scripts/t/040_createuser.pl | 18 +++++++++---------
3 files changed, 24 insertions(+), 17 deletions(-)



Message-ID: <E1pZAkq-002BxW-Rd@gemulon.postgresql.org>
Permalink:  ../E1pZAkq-002BxW-Rd@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pZAkq-002BxW-Rd@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: dgustafsson@postgresql.org
  Subject: Re: pgsql: Fix handling of default option values in createuser
  In-Reply-To: <E1pZAkq-002BxW-Rd@gemulon.postgresql.org>
  References: <E1pZAkq-002BxW-Rd@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox