pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: In basebackup.c, perform end-of-file test after checksum validat
Date: Mon, 06 Mar 2023 15:26:22 +0000
Message-ID: <E1pZCjF-002Cps-Rc@gemulon.postgresql.org> (raw)

In basebackup.c, perform end-of-file test after checksum validation.

We read blocks of data from files that we're backing up in chunks,
some multiple of BLCKSZ for each read. If checksum verification fails,
we then try rereading just the one block for which validation failed.
If that block happened to be the first block of the chunk, and if
the file was concurrently truncated to remove that block, then we'd
reach a call to bbsink_archive_contents() with a buffer length of 0.
That causes an assertion failure.

As far as I can see, there are no particularly bad consequences if
this happens in a non-assert build, and it's pretty unlikely to happen
in the first place because it requires a series of somewhat unlikely
things to happen in very quick succession. However, assertion failures
are bad, so rearrange the code to avoid that possibility.

Patch by me, reviewed by Michael Paquier.

Discussion: http://postgr.es/m/CA+TgmoZ_fFAoU6mrHt9QBs+dcYhN6yXenGTTMRebZNhtwPwHyg@mail.gmail.com

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/349803b18fee2476c7c9c84039d04c900ce8d499

Modified Files
--------------
src/backend/backup/basebackup.c | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)



view thread (2+ messages)

Message-ID: <E1pZCjF-002Cps-Rc@gemulon.postgresql.org>
Permalink:  ../E1pZCjF-002Cps-Rc@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pZCjF-002Cps-Rc@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: rhaas@postgresql.org
  Subject: Re: pgsql: In basebackup.c, perform end-of-file test after checksum validat
  In-Reply-To: <E1pZCjF-002Cps-Rc@gemulon.postgresql.org>
  References: <E1pZCjF-002Cps-Rc@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox