pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Reword overly-optimistic comment about backup checksum verificat
Date: Mon, 06 Mar 2023 15:41:47 +0000
Message-ID: <E1pZCyB-002CxM-0R@gemulon.postgresql.org> (raw)

Reword overly-optimistic comment about backup checksum verification.

The comment implies that a single retry is sufficient to avoid
spurious checksum failures, but in fact no number of retries is
sufficient for that purpose. Update the comment accordingly.

Patch by me, reviewed by Michael Paquier.

Discussion: http://postgr.es/m/CA+TgmoZ_fFAoU6mrHt9QBs+dcYhN6yXenGTTMRebZNhtwPwHyg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e76cbb6cd64d9c9cdf76a56318ba5249bf694b69

Modified Files
--------------
src/backend/backup/basebackup.c | 20 +++++++++++++++-----
1 file changed, 15 insertions(+), 5 deletions(-)



Message-ID: <E1pZCyB-002CxM-0R@gemulon.postgresql.org>
Permalink:  ../E1pZCyB-002CxM-0R@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pZCyB-002CxM-0R@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: rhaas@postgresql.org
  Subject: Re: pgsql: Reword overly-optimistic comment about backup checksum verificat
  In-Reply-To: <E1pZCyB-002CxM-0R@gemulon.postgresql.org>
  References: <E1pZCyB-002CxM-0R@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox