pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix some more cases of missed GENERATED-column updates.
Date: Mon, 06 Mar 2023 23:31:41 +0000
Message-ID: <E1pZKIv-002G8o-6y@gemulon.postgresql.org> (raw)

Fix some more cases of missed GENERATED-column updates.

If UPDATE is forced to retry after an EvalPlanQual check, it neglected
to repeat GENERATED-column computations, even though those might well
have changed since we're dealing with a different tuple than before.
Fixing this is mostly a matter of looping back a bit further when
we retry.  In v15 and HEAD that's most easily done by altering the API
of ExecUpdateAct so that it includes computing GENERATED expressions.

Also, if an UPDATE in a partitioned table turns into a cross-partition
INSERT operation, we failed to recompute GENERATED columns.  That's a
bug since 8bf6ec3ba allowed partitions to have different generation
expressions; although it seems to have no ill effects before that.
Fixing this is messier because we can now have situations where the same
query needs both the UPDATE-aligned set of GENERATED columns and the
INSERT-aligned set, and it's unclear which set will be generated first
(else we could hack things by forcing the INSERT-aligned set to be
generated, which is indeed how fe9e658f4 made it work for MERGE).
The best fix seems to be to build and store separate sets of expressions
for the INSERT and UPDATE cases.  That would create ABI issues in the
back branches, but so far it seems we can leave this alone in the back
branches.

Per bug #17823 from Hisahiro Kauchi.  The first part of this affects all
branches back to v12 where GENERATED columns were added.

Discussion: https://postgr.es/m/17823-b64909cf7d63de84@postgresql.org

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/70ef509543fab4c35f79e73dd2b309cc75ceed51

Modified Files
--------------
src/backend/executor/execUtils.c               |   2 +-
src/backend/executor/nodeModifyTable.c         |  42 ++--
src/test/isolation/expected/eval-plan-qual.out | 304 +++++++++++++------------
src/test/isolation/specs/eval-plan-qual.spec   |  21 +-
src/test/regress/expected/generated.out        |  14 ++
src/test/regress/sql/generated.sql             |   4 +
6 files changed, 221 insertions(+), 166 deletions(-)



view thread (5+ messages)  latest in thread

Message-ID: <E1pZKIv-002G8o-6y@gemulon.postgresql.org>
Permalink:  ../E1pZKIv-002G8o-6y@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pZKIv-002G8o-6y@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Fix some more cases of missed GENERATED-column updates.
  In-Reply-To: <E1pZKIv-002G8o-6y@gemulon.postgresql.org>
  References: <E1pZKIv-002G8o-6y@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox