pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve/correct comments
Date: Thu, 09 Mar 2023 09:00:37 +0000
Message-ID: <E1paC8a-002ej6-Sw@gemulon.postgresql.org> (raw)

Improve/correct comments

Change comments for pg_cryptohash_init(), pg_cryptohash_update(),
pg_cryptohash_final() in cryptohash.c to match cryptohash_openssl.c.
In particular, the claim that these functions were "designed" to never
fail was incorrect, since by design callers need to be prepared to
handle failures, for compatibility with the cryptohash_openssl.c
versions.

Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Discussion: https://www.postgresql.org/message-id/301F4EDD-27B9-460F-B462-B9DB2BDE4ACF@yesql.se

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/36ea345f8fa616fd9b40576310e54145aa70c1a1

Modified Files
--------------
src/common/cryptohash.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)



Message-ID: <E1paC8a-002ej6-Sw@gemulon.postgresql.org>
Permalink:  ../E1paC8a-002ej6-Sw@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1paC8a-002ej6-Sw@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org
  Subject: Re: pgsql: Improve/correct comments
  In-Reply-To: <E1paC8a-002ej6-Sw@gemulon.postgresql.org>
  References: <E1paC8a-002ej6-Sw@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox