pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Avoid criticizable perl code
Date: Thu, 09 Mar 2023 11:02:49 +0000
Message-ID: <E1paE2r-002frd-85@gemulon.postgresql.org> (raw)

Avoid criticizable perl code

Using `require` / `->import` instead of `use` avoids the use of a
"stringy eval", making for cleaner code that we don't need to silence
perlcritic about.

Per Andrew Dunstan

Discussion: https://postgr.es/m/7cd3bbbd-0216-4436-d571-8f80c9259a07@dunslane.net

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/590a075789b541d5c1a190031fdcf061355bcfbc

Modified Files
--------------
src/test/modules/libpq_pipeline/t/001_libpq_pipeline.pl | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)



Message-ID: <E1paE2r-002frd-85@gemulon.postgresql.org>
Permalink:  ../E1paE2r-002frd-85@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1paE2r-002frd-85@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org
  Subject: Re: pgsql: Avoid criticizable perl code
  In-Reply-To: <E1paE2r-002frd-85@gemulon.postgresql.org>
  References: <E1paE2r-002frd-85@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox