pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Remove incidental md5() function uses from main regression tests 5+ messages / 2 participants [nested] [flat]
* pgsql: Remove incidental md5() function uses from main regression tests @ 2023-03-13 10:01 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 5+ messages in thread From: Peter Eisentraut @ 2023-03-13 10:01 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove incidental md5() function uses from main regression tests Most of these calls were to generate some random data. These can be replaced by appropriately adapted sha256() calls. To keep the diff smaller, we wrap this into a helper function that produces the same output format and length as the md5() call. This will eventually allow these tests to pass in OpenSSL FIPS mode (which does not allow MD5 use). Similar work for other test suites will follow later. Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://www.postgresql.org/message-id/flat/dbbd927f-ef1f-c9a1-4ec6-c759778ac852@enterprisedb.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/208bf364a9cc80cc586d060726d076ba7d0c8dec Modified Files -------------- src/test/regress/expected/arrays.out | 6 +- src/test/regress/expected/brin.out | 4 +- src/test/regress/expected/brin_multi.out | 6 +- src/test/regress/expected/compression.out | 8 +- src/test/regress/expected/compression_1.out | 8 +- src/test/regress/expected/inherit.out | 2 +- src/test/regress/expected/largeobject.out | 2 +- src/test/regress/expected/largeobject_1.out | 2 +- src/test/regress/expected/matview.out | 8 +- src/test/regress/expected/memoize.out | 2 +- src/test/regress/expected/plpgsql.out | 20 +- src/test/regress/expected/rowsecurity.out | 546 ++++++++++++++-------------- src/test/regress/expected/stats_ext.out | 18 +- src/test/regress/expected/test_setup.out | 12 + src/test/regress/sql/arrays.sql | 6 +- src/test/regress/sql/brin.sql | 4 +- src/test/regress/sql/brin_multi.sql | 6 +- src/test/regress/sql/compression.sql | 4 +- src/test/regress/sql/inherit.sql | 2 +- src/test/regress/sql/largeobject.sql | 2 +- src/test/regress/sql/matview.sql | 8 +- src/test/regress/sql/memoize.sql | 2 +- src/test/regress/sql/plpgsql.sql | 2 +- src/test/regress/sql/rowsecurity.sql | 14 +- src/test/regress/sql/stats_ext.sql | 18 +- src/test/regress/sql/test_setup.sql | 15 + 26 files changed, 374 insertions(+), 353 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Remove incidental md5() function uses from several tests @ 2023-07-04 12:45 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 5+ messages in thread From: Peter Eisentraut @ 2023-07-04 12:45 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove incidental md5() function uses from several tests This removes md5() function calls from these test suites: - bloom - test_decoding - isolation - recovery - subscription This covers all remaining test suites where md5() calls were just used to generate some random data and can be replaced by appropriately adapted sha256() calls. This will eventually allow these tests to pass in OpenSSL FIPS mode (which does not allow MD5 use). See also 208bf364a9. Unlike for the main regression tests, I didn't write a fipshash() wrapper here, because that would have been too repetitive and wouldn't really save much here. In some cases it was easier to remove one layer of indirection by changing column types from text to bytea. Reviewed-by: Daniel Gustafsson <daniel@yesql.se> Discussion: https://www.postgresql.org/message-id/flat/f9b480b5-e473-d2d1-223a-4b9db30a229a@eisentraut.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/657f5f223e8fd9aa12d8d9fc473faecc267b9b7a Modified Files -------------- contrib/bloom/expected/bloom.out | 32 ++++++++++---------- contrib/bloom/sql/bloom.sql | 8 ++--- contrib/bloom/t/001_wal.pl | 4 +-- .../test_decoding/expected/concurrent_stream.out | 6 ++-- contrib/test_decoding/specs/concurrent_stream.spec | 8 ++--- .../specs/insert-conflict-specconflict.spec | 2 +- src/test/recovery/t/015_promotion_pages.pl | 4 +-- src/test/recovery/t/026_overwrite_contrecord.pl | 2 +- src/test/subscription/t/008_diff_schema.pl | 4 +-- src/test/subscription/t/015_stream.pl | 16 +++++----- src/test/subscription/t/016_stream_subxact.pl | 24 +++++++-------- src/test/subscription/t/017_stream_ddl.pl | 18 ++++++------ .../subscription/t/018_stream_subxact_abort.pl | 34 +++++++++++----------- .../subscription/t/019_stream_subxact_ddl_abort.pl | 14 ++++----- src/test/subscription/t/022_twophase_cascade.pl | 14 ++++----- src/test/subscription/t/023_twophase_stream.pl | 24 +++++++-------- src/test/subscription/t/029_on_error.pl | 8 ++--- 17 files changed, 111 insertions(+), 111 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Remove incidental md5() function use from test @ 2024-08-16 15:31 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 5+ messages in thread From: Peter Eisentraut @ 2024-08-16 15:31 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove incidental md5() function use from test To allow test to pass in OpenSSL FIPS mode, similar to 657f5f223e, for a new test that has been added since. Reviewed-by: Tomas Vondra <tomas@vondra.me> Discussion: https://www.postgresql.org/message-id/86763810-70a1-4872-8ba7-1676f788e5a2@eisentraut.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/95b856de23c72bbb46b7c5430fa6897002d2908e Modified Files -------------- contrib/pageinspect/expected/brin.out | 10 +++++----- contrib/pageinspect/sql/brin.sql | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Remove incidental md5() function use from test @ 2024-08-16 15:31 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 5+ messages in thread From: Peter Eisentraut @ 2024-08-16 15:31 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove incidental md5() function use from test To allow test to pass in OpenSSL FIPS mode, similar to 657f5f223e, for a new test that has been added since. Reviewed-by: Tomas Vondra <tomas@vondra.me> Discussion: https://www.postgresql.org/message-id/86763810-70a1-4872-8ba7-1676f788e5a2@eisentraut.org Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/47b47a5617fa0c49e5d8788d5f1150c21485f3ff Modified Files -------------- contrib/pageinspect/expected/brin.out | 10 +++++----- contrib/pageinspect/sql/brin.sql | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Remove incidental md5() function use from test @ 2025-03-30 12:13 Tomas Vondra <tomas.vondra@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Tomas Vondra @ 2025-03-30 12:13 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove incidental md5() function use from test Replace md5() with sha256() in tests introduced in 14ffaece0fb5, to allow test to pass in OpenSSL FIPS mode. Reported-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/3518736.1743307492@sss.pgh.pa.us Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/49b82522f13fa5f756687f5609f687877fc970ff Modified Files -------------- contrib/amcheck/expected/check_gin.out | 4 ++-- contrib/amcheck/sql/check_gin.sql | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2025-03-30 12:13 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-03-13 10:01 pgsql: Remove incidental md5() function uses from main regression tests Peter Eisentraut <peter@eisentraut.org> 2023-07-04 12:45 pgsql: Remove incidental md5() function uses from several tests Peter Eisentraut <peter@eisentraut.org> 2024-08-16 15:31 pgsql: Remove incidental md5() function use from test Peter Eisentraut <peter@eisentraut.org> 2024-08-16 15:31 pgsql: Remove incidental md5() function use from test Peter Eisentraut <peter@eisentraut.org> 2025-03-30 12:13 pgsql: Remove incidental md5() function use from test Tomas Vondra <tomas.vondra@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox