From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove incidental md5() function uses from several tests
Date: Tue, 04 Jul 2023 12:45:08 +0000
Message-ID: <E1qGfP2-001s3f-Kp@gemulon.postgresql.org> (raw)
Remove incidental md5() function uses from several tests
This removes md5() function calls from these test suites:
- bloom
- test_decoding
- isolation
- recovery
- subscription
This covers all remaining test suites where md5() calls were just used
to generate some random data and can be replaced by appropriately
adapted sha256() calls. This will eventually allow these tests to
pass in OpenSSL FIPS mode (which does not allow MD5 use). See also
208bf364a9. Unlike for the main regression tests, I didn't write a
fipshash() wrapper here, because that would have been too repetitive
and wouldn't really save much here. In some cases it was easier to
remove one layer of indirection by changing column types from text to
bytea.
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Discussion: https://www.postgresql.org/message-id/flat/f9b480b5-e473-d2d1-223a-4b9db30a229a@eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/657f5f223e8fd9aa12d8d9fc473faecc267b9b7a
Modified Files
--------------
contrib/bloom/expected/bloom.out | 32 ++++++++++----------
contrib/bloom/sql/bloom.sql | 8 ++---
contrib/bloom/t/001_wal.pl | 4 +--
.../test_decoding/expected/concurrent_stream.out | 6 ++--
contrib/test_decoding/specs/concurrent_stream.spec | 8 ++---
.../specs/insert-conflict-specconflict.spec | 2 +-
src/test/recovery/t/015_promotion_pages.pl | 4 +--
src/test/recovery/t/026_overwrite_contrecord.pl | 2 +-
src/test/subscription/t/008_diff_schema.pl | 4 +--
src/test/subscription/t/015_stream.pl | 16 +++++-----
src/test/subscription/t/016_stream_subxact.pl | 24 +++++++--------
src/test/subscription/t/017_stream_ddl.pl | 18 ++++++------
.../subscription/t/018_stream_subxact_abort.pl | 34 +++++++++++-----------
.../subscription/t/019_stream_subxact_ddl_abort.pl | 14 ++++-----
src/test/subscription/t/022_twophase_cascade.pl | 14 ++++-----
src/test/subscription/t/023_twophase_stream.pl | 24 +++++++--------
src/test/subscription/t/029_on_error.pl | 8 ++---
17 files changed, 111 insertions(+), 111 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove incidental md5() function uses from several tests
In-Reply-To: <E1qGfP2-001s3f-Kp@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox