pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix JSON error reporting for many cases of erroneous string valu
Date: Mon, 13 Mar 2023 19:19:17 +0000
Message-ID: <E1pbnhV-003NWV-0g@gemulon.postgresql.org> (raw)

Fix JSON error reporting for many cases of erroneous string values.

The majority of error exit cases in json_lex_string() failed to
set lex->token_terminator, causing problems for the error context
reporting code: it would see token_terminator less than token_start
and do something more or less nuts.  In v14 and up the end result
could be as bad as a crash in report_json_context().  Older
versions accidentally avoided that fate; but all versions produce
error context lines that are far less useful than intended,
because they'd stop at the end of the prior token instead of
continuing to where the actually-bad input is.

To fix, invent some macros that make it less notationally painful
to do the right thing.  Also add documentation about what the
function is actually required to do; and in >= v14, add an assertion
in report_json_context about token_terminator being sufficiently
far advanced.

Per report from Nikolay Shaplov.  Back-patch to all supported
versions.

Discussion: https://postgr.es/m/7332649.x5DLKWyVIX@thinkpad-pgpro

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/234941a3bbf32266e9e2d3d9bc7648aec850d8c4

Modified Files
--------------
src/backend/utils/adt/json.c                  | 29 +++++++++++++++++++--
src/test/regress/expected/json_encoding.out   | 24 +++++++++---------
src/test/regress/expected/json_encoding_1.out | 36 +++++++++++++--------------
3 files changed, 57 insertions(+), 32 deletions(-)



view thread (6+ messages)  latest in thread

Message-ID: <E1pbnhV-003NWV-0g@gemulon.postgresql.org>
Permalink:  ../E1pbnhV-003NWV-0g@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pbnhV-003NWV-0g@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix JSON error reporting for many cases of erroneous string valu
  In-Reply-To: <E1pbnhV-003NWV-0g@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox