pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Support PlaceHolderVars in MERGE actions. 2+ messages / 1 participants [nested] [flat]
* pgsql: Support PlaceHolderVars in MERGE actions. @ 2023-03-15 15:59 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2023-03-15 15:59 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Support PlaceHolderVars in MERGE actions. preprocess_targetlist thought PHVs couldn't appear here. It was mistaken, as per report from Önder Kalacı. Surveying other pull_var_clause calls, I noted no similar errors, but I did notice that qual_is_pushdown_safe's assertion about !contain_window_function was pointless, because the following pull_var_clause call would complain about them anyway. In HEAD only, remove the redundant Assert and improve the commentary. Discussion: https://postgr.es/m/CACawEhUuum-gC_2S3sXLTcsk7bUSPSHOD+g1ZpfKaDK-KKPPWA@mail.gmail.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3908d6ae115801cc61486b286ab71d91c2cdbb99 Modified Files -------------- src/backend/optimizer/prep/preptlist.c | 12 +++++------- src/test/regress/expected/merge.out | 21 +++++++++++++++++++++ src/test/regress/sql/merge.sql | 10 ++++++++++ 3 files changed, 36 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Support PlaceHolderVars in MERGE actions. @ 2023-03-15 15:59 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2023-03-15 15:59 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Support PlaceHolderVars in MERGE actions. preprocess_targetlist thought PHVs couldn't appear here. It was mistaken, as per report from Önder Kalacı. Surveying other pull_var_clause calls, I noted no similar errors, but I did notice that qual_is_pushdown_safe's assertion about !contain_window_function was pointless, because the following pull_var_clause call would complain about them anyway. In HEAD only, remove the redundant Assert and improve the commentary. Discussion: https://postgr.es/m/CACawEhUuum-gC_2S3sXLTcsk7bUSPSHOD+g1ZpfKaDK-KKPPWA@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/e3ac85014eb280ee2e82b36dc3be1b62c838b3e4 Modified Files -------------- src/backend/optimizer/path/allpaths.c | 12 +++++------- src/backend/optimizer/prep/preptlist.c | 12 +++++------- src/test/regress/expected/merge.out | 21 +++++++++++++++++++++ src/test/regress/sql/merge.sql | 10 ++++++++++ 4 files changed, 41 insertions(+), 14 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2023-03-15 15:59 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-03-15 15:59 pgsql: Support PlaceHolderVars in MERGE actions. Tom Lane <tgl@sss.pgh.pa.us> 2023-03-15 15:59 pgsql: Support PlaceHolderVars in MERGE actions. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox