pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Support PlaceHolderVars in MERGE actions.
Date: Wed, 15 Mar 2023 15:59:28 +0000
Message-ID: <E1pcTXE-003gMH-0W@gemulon.postgresql.org> (raw)

Support PlaceHolderVars in MERGE actions.

preprocess_targetlist thought PHVs couldn't appear here.
It was mistaken, as per report from Önder Kalacı.

Surveying other pull_var_clause calls, I noted no similar errors,
but I did notice that qual_is_pushdown_safe's assertion about
!contain_window_function was pointless, because the following
pull_var_clause call would complain about them anyway.  In HEAD
only, remove the redundant Assert and improve the commentary.

Discussion: https://postgr.es/m/CACawEhUuum-gC_2S3sXLTcsk7bUSPSHOD+g1ZpfKaDK-KKPPWA@mail.gmail.com

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/3908d6ae115801cc61486b286ab71d91c2cdbb99

Modified Files
--------------
src/backend/optimizer/prep/preptlist.c | 12 +++++-------
src/test/regress/expected/merge.out    | 21 +++++++++++++++++++++
src/test/regress/sql/merge.sql         | 10 ++++++++++
3 files changed, 36 insertions(+), 7 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1pcTXE-003gMH-0W@gemulon.postgresql.org>
Permalink:  ../E1pcTXE-003gMH-0W@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1pcTXE-003gMH-0W@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Support PlaceHolderVars in MERGE actions.
  In-Reply-To: <E1pcTXE-003gMH-0W@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox