pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Small tidyup for commit d41a178b.
8+ messages / 3 participants
[nested] [flat]
Commits from this thread:
2023-03-17 10b6745d31 e8a774d007 1c0d4affa2 77a8133c95 8fcd1517f0 b23f2a729c Small tidyup for commit d41a178b, part II.
* pgsql: Small tidyup for commit d41a178b.
@ 2023-03-16 21:47 Thomas Munro <tmunro@postgresql.org>
2023-03-17 00:36 ` Re: pgsql: Small tidyup for commit d41a178b. Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 8+ messages in thread
From: Thomas Munro @ 2023-03-16 21:47 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Small tidyup for commit d41a178b.
A comment was left behind claiming that we needed to use malloc() rather
than palloc() because the corresponding free would run in another
thread, but that's not true anymore. Remove that comment. And, with
the reason being gone, we might as well actually use palloc().
Back-patch to supported releases, like d41a178b.
Discussion: https://postgr.es/m/CA%2BhUKG%2BpdM9v3Jv4tc2BFx2jh_daY3uzUyAGBhtDkotEQDNPYw%40mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/6a9229da65c9553a1268764d46fb28043b83bfd6
Modified Files
--------------
src/backend/postmaster/postmaster.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: pgsql: Small tidyup for commit d41a178b.
2023-03-16 21:47 pgsql: Small tidyup for commit d41a178b. Thomas Munro <tmunro@postgresql.org>
@ 2023-03-17 00:36 ` Tom Lane <tgl@sss.pgh.pa.us>
2023-03-17 00:51 ` Re: pgsql: Small tidyup for commit d41a178b. Thomas Munro <thomas.munro@gmail.com>
0 siblings, 1 reply; 8+ messages in thread
From: Tom Lane @ 2023-03-17 00:36 UTC (permalink / raw)
To: Thomas Munro <tmunro@postgresql.org>; +Cc: pgsql-committers@lists.postgresql.org
Thomas Munro <tmunro@postgresql.org> writes:
> Small tidyup for commit d41a178b.
> A comment was left behind claiming that we needed to use malloc() rather
> than palloc() because the corresponding free would run in another
> thread, but that's not true anymore. Remove that comment. And, with
> the reason being gone, we might as well actually use palloc().
Hm, doesn't the change to palloc make the following error check redundant?
childinfo = palloc(sizeof(win32_deadchild_waitinfo));
- if (!childinfo)
- ereport(FATAL,
- (errcode(ERRCODE_OUT_OF_MEMORY),
- errmsg("out of memory")));
-
childinfo->procHandle = pi.hProcess;
childinfo->procId = pi.dwProcessId;
regards, tom lane
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: pgsql: Small tidyup for commit d41a178b.
2023-03-16 21:47 pgsql: Small tidyup for commit d41a178b. Thomas Munro <tmunro@postgresql.org>
2023-03-17 00:36 ` Re: pgsql: Small tidyup for commit d41a178b. Tom Lane <tgl@sss.pgh.pa.us>
@ 2023-03-17 00:51 ` Thomas Munro <thomas.munro@gmail.com>
0 siblings, 0 replies; 8+ messages in thread
From: Thomas Munro @ 2023-03-17 00:51 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Thomas Munro <tmunro@postgresql.org>; pgsql-committers@lists.postgresql.org
On Fri, Mar 17, 2023 at 1:36 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Thomas Munro <tmunro@postgresql.org> writes:
> > Small tidyup for commit d41a178b.
> > A comment was left behind claiming that we needed to use malloc() rather
> > than palloc() because the corresponding free would run in another
> > thread, but that's not true anymore. Remove that comment. And, with
> > the reason being gone, we might as well actually use palloc().
>
> Hm, doesn't the change to palloc make the following error check redundant?
>
> childinfo = palloc(sizeof(win32_deadchild_waitinfo));
> - if (!childinfo)
> - ereport(FATAL,
> - (errcode(ERRCODE_OUT_OF_MEMORY),
> - errmsg("out of memory")));
> -
> childinfo->procHandle = pi.hProcess;
> childinfo->procId = pi.dwProcessId;
True. Will fix.
^ permalink raw reply [nested|flat] 8+ messages in thread
* pgsql: Small tidyup for commit d41a178b.
@ 2023-03-16 21:47 Thomas Munro <tmunro@postgresql.org>
0 siblings, 0 replies; 8+ messages in thread
From: Thomas Munro @ 2023-03-16 21:47 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Small tidyup for commit d41a178b.
A comment was left behind claiming that we needed to use malloc() rather
than palloc() because the corresponding free would run in another
thread, but that's not true anymore. Remove that comment. And, with
the reason being gone, we might as well actually use palloc().
Back-patch to supported releases, like d41a178b.
Discussion: https://postgr.es/m/CA%2BhUKG%2BpdM9v3Jv4tc2BFx2jh_daY3uzUyAGBhtDkotEQDNPYw%40mail.gmail.com
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/75e7378f6e15271385d50543a031b1a3bee6be13
Modified Files
--------------
src/backend/postmaster/postmaster.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
^ permalink raw reply [nested|flat] 8+ messages in thread
* pgsql: Small tidyup for commit d41a178b.
@ 2023-03-16 21:47 Thomas Munro <tmunro@postgresql.org>
0 siblings, 0 replies; 8+ messages in thread
From: Thomas Munro @ 2023-03-16 21:47 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Small tidyup for commit d41a178b.
A comment was left behind claiming that we needed to use malloc() rather
than palloc() because the corresponding free would run in another
thread, but that's not true anymore. Remove that comment. And, with
the reason being gone, we might as well actually use palloc().
Back-patch to supported releases, like d41a178b.
Discussion: https://postgr.es/m/CA%2BhUKG%2BpdM9v3Jv4tc2BFx2jh_daY3uzUyAGBhtDkotEQDNPYw%40mail.gmail.com
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/00fc4b3a31010033e8b1a964c90a7a30b8d6a7d7
Modified Files
--------------
src/backend/postmaster/postmaster.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
^ permalink raw reply [nested|flat] 8+ messages in thread
* pgsql: Small tidyup for commit d41a178b.
@ 2023-03-16 21:47 Thomas Munro <tmunro@postgresql.org>
0 siblings, 0 replies; 8+ messages in thread
From: Thomas Munro @ 2023-03-16 21:47 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Small tidyup for commit d41a178b.
A comment was left behind claiming that we needed to use malloc() rather
than palloc() because the corresponding free would run in another
thread, but that's not true anymore. Remove that comment. And, with
the reason being gone, we might as well actually use palloc().
Back-patch to supported releases, like d41a178b.
Discussion: https://postgr.es/m/CA%2BhUKG%2BpdM9v3Jv4tc2BFx2jh_daY3uzUyAGBhtDkotEQDNPYw%40mail.gmail.com
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/798dae9f65e379c0f4f22d7a6096287ea50ffb41
Modified Files
--------------
src/backend/postmaster/postmaster.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
^ permalink raw reply [nested|flat] 8+ messages in thread
* pgsql: Small tidyup for commit d41a178b.
@ 2023-03-16 21:47 Thomas Munro <tmunro@postgresql.org>
0 siblings, 0 replies; 8+ messages in thread
From: Thomas Munro @ 2023-03-16 21:47 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Small tidyup for commit d41a178b.
A comment was left behind claiming that we needed to use malloc() rather
than palloc() because the corresponding free would run in another
thread, but that's not true anymore. Remove that comment. And, with
the reason being gone, we might as well actually use palloc().
Back-patch to supported releases, like d41a178b.
Discussion: https://postgr.es/m/CA%2BhUKG%2BpdM9v3Jv4tc2BFx2jh_daY3uzUyAGBhtDkotEQDNPYw%40mail.gmail.com
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/6f508b8bce2ed66eef310e1b77a84ce1cd222aeb
Modified Files
--------------
src/backend/postmaster/postmaster.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
^ permalink raw reply [nested|flat] 8+ messages in thread
* pgsql: Small tidyup for commit d41a178b.
@ 2023-03-16 21:48 Thomas Munro <tmunro@postgresql.org>
0 siblings, 0 replies; 8+ messages in thread
From: Thomas Munro @ 2023-03-16 21:48 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Small tidyup for commit d41a178b.
A comment was left behind claiming that we needed to use malloc() rather
than palloc() because the corresponding free would run in another
thread, but that's not true anymore. Remove that comment. And, with
the reason being gone, we might as well actually use palloc().
Back-patch to supported releases, like d41a178b.
Discussion: https://postgr.es/m/CA%2BhUKG%2BpdM9v3Jv4tc2BFx2jh_daY3uzUyAGBhtDkotEQDNPYw%40mail.gmail.com
Branch
------
REL_11_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/9d6c3439716f04e1dea92376e794ddde98624e3b
Modified Files
--------------
src/backend/postmaster/postmaster.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
^ permalink raw reply [nested|flat] 8+ messages in thread
end of thread, other threads:[~2023-03-17 00:51 UTC | newest]
Thread overview: 8+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-03-16 21:47 pgsql: Small tidyup for commit d41a178b. Thomas Munro <tmunro@postgresql.org>
2023-03-17 00:36 ` Tom Lane <tgl@sss.pgh.pa.us>
2023-03-17 00:51 ` Thomas Munro <thomas.munro@gmail.com>
2023-03-16 21:47 pgsql: Small tidyup for commit d41a178b. Thomas Munro <tmunro@postgresql.org>
2023-03-16 21:47 pgsql: Small tidyup for commit d41a178b. Thomas Munro <tmunro@postgresql.org>
2023-03-16 21:47 pgsql: Small tidyup for commit d41a178b. Thomas Munro <tmunro@postgresql.org>
2023-03-16 21:47 pgsql: Small tidyup for commit d41a178b. Thomas Munro <tmunro@postgresql.org>
2023-03-16 21:48 pgsql: Small tidyup for commit d41a178b. Thomas Munro <tmunro@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox